Implement Image::GetAsSourceSurface

RESOLVED FIXED in mozilla29

Status

()

RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: ali, Assigned: ali)

Tracking

28 Branch
mozilla29
x86
Mac OS X
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [qa-])

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

5 years ago
User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_9_1) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/31.0.1650.63 Safari/537.36

Steps to reproduce:

Implement generic Image::GetAsSourceSurface and deprecate Image::GetAsSurface so that we can slowly transition away from using gfxASurface's returned from the Image classes and it's subclasses.
(Assignee)

Updated

5 years ago
Blocks: 947194
(Assignee)

Updated

5 years ago
Blocks: 958490
(Assignee)

Updated

5 years ago
Blocks: 959121
(Assignee)

Updated

5 years ago
Depends on: 959123
(Assignee)

Updated

5 years ago
Depends on: 959124
Assignee: nobody → ali
(Assignee)

Updated

5 years ago
No longer depends on: 959124
(Assignee)

Updated

5 years ago
No longer depends on: 959123
(Assignee)

Comment 1

5 years ago
Created attachment 8359693 [details] [diff] [review]
Implement base Image::GetAsSourceSurface

Added an Image::GetAsSourceSurface to return a gfx::SourceSurface
and implemented in terms of gfxPlatform::GetSourceSurfaceForSurface.

Deprecated GetAsSurface.

Modified the following files replaceing ::GetAsSurface with
::DeprecatedGetAsSurface and modified calleres.

	modified:   gfx/layers/D3D9SurfaceImage.cpp
	modified:   gfx/layers/D3D9SurfaceImage.h
	modified:   gfx/layers/GrallocImages.cpp
	modified:   gfx/layers/GrallocImages.h
	modified:   gfx/layers/ImageContainer.cpp
	modified:   gfx/layers/ImageContainer.h
	modified:   gfx/layers/MacIOSurfaceImage.h
	modified:   gfx/layers/SharedTextureImage.h
	modified:   gfx/layers/basic/BasicImages.cpp
	modified:   gfx/layers/client/ImageClient.cpp
	modified:   gfx/layers/d3d10/ImageLayerD3D10.cpp
	modified:   gfx/layers/d3d10/ImageLayerD3D10.h
	modified:   gfx/layers/ipc/SharedPlanarYCbCrImage.cpp
	modified:   gfx/layers/ipc/SharedPlanarYCbCrImage.h
	modified:   gfx/layers/ipc/SharedRGBImage.cpp
	modified:   gfx/layers/ipc/SharedRGBImage.h
(Assignee)

Comment 3

5 years ago
Created attachment 8360367 [details] [diff] [review]
Implement base Image::GetAsSourceSurface. carries r=nical.

Added an Image::GetAsSourceSurface to return a gfx::SourceSurface
and implemented in terms of gfxPlatform::GetSourceSurfaceForSurface.

Deprecated GetAsSurface.

Modified the following files replaceing ::GetAsSurface with
::DeprecatedGetAsSurface and modified calleres.

	modified:   gfx/layers/D3D9SurfaceImage.cpp
	modified:   gfx/layers/D3D9SurfaceImage.h
	modified:   gfx/layers/GrallocImages.cpp
	modified:   gfx/layers/GrallocImages.h
	modified:   gfx/layers/ImageContainer.cpp
	modified:   gfx/layers/ImageContainer.h
	modified:   gfx/layers/MacIOSurfaceImage.h
	modified:   gfx/layers/SharedTextureImage.h
	modified:   gfx/layers/basic/BasicImages.cpp
	modified:   gfx/layers/client/ImageClient.cpp
	modified:   gfx/layers/d3d10/ImageLayerD3D10.cpp
	modified:   gfx/layers/d3d10/ImageLayerD3D10.h
	modified:   gfx/layers/ipc/SharedPlanarYCbCrImage.cpp
	modified:   gfx/layers/ipc/SharedPlanarYCbCrImage.h
	modified:   gfx/layers/ipc/SharedRGBImage.cpp
	modified:   gfx/layers/ipc/SharedRGBImage.h
Attachment #8359693 - Attachment is obsolete: true
(Assignee)

Updated

5 years ago
Keywords: checkin-needed

Updated

5 years ago
Attachment #8360367 - Flags: review+
https://hg.mozilla.org/mozilla-central/rev/9ec76cf42e4c
Status: UNCONFIRMED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla29

Updated

5 years ago
Whiteboard: [qa-]
You need to log in before you can comment on or make changes to this bug.