Closed Bug 958550 Opened 6 years ago Closed 6 years ago

Use ScopedGLState for scissor test + blend state in two more places

Categories

(Core :: Graphics, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla29

People

(Reporter: mstange, Assigned: mstange)

References

Details

Attachments

(1 file)

Attached patch v1Splinter Review
These are the remaining places in layers where fEnable/fDisable is called with LOCAL_GL_SCISSOR_TEST directly. The one in GLBlitTextureImageHelper.cpp didn't even restore the previous state, it enabled the scissor test afterwards indiscriminately.

With these patches, we could remove the explicit disabling from nsChildView::DrawWindowOverlay, but we may as well keep it.
Attachment #8358431 - Flags: review?(bjacob)
Comment on attachment 8358431 [details] [diff] [review]
v1

Review of attachment 8358431 [details] [diff] [review]:
-----------------------------------------------------------------

Very good catch!
Attachment #8358431 - Flags: review?(bjacob) → review+
https://hg.mozilla.org/mozilla-central/rev/19a848c2410c
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla29
Depends on: 961229
You need to log in before you can comment on or make changes to this bug.