Closed
Bug 958550
Opened 10 years ago
Closed 10 years ago
Use ScopedGLState for scissor test + blend state in two more places
Categories
(Core :: Graphics, defect)
Core
Graphics
Tracking
()
RESOLVED
FIXED
mozilla29
People
(Reporter: mstange, Assigned: mstange)
References
Details
Attachments
(1 file)
4.28 KB,
patch
|
bjacob
:
review+
|
Details | Diff | Splinter Review |
These are the remaining places in layers where fEnable/fDisable is called with LOCAL_GL_SCISSOR_TEST directly. The one in GLBlitTextureImageHelper.cpp didn't even restore the previous state, it enabled the scissor test afterwards indiscriminately. With these patches, we could remove the explicit disabling from nsChildView::DrawWindowOverlay, but we may as well keep it.
Attachment #8358431 -
Flags: review?(bjacob)
Comment 1•10 years ago
|
||
Comment on attachment 8358431 [details] [diff] [review] v1 Review of attachment 8358431 [details] [diff] [review]: ----------------------------------------------------------------- Very good catch!
Attachment #8358431 -
Flags: review?(bjacob) → review+
Assignee | ||
Comment 2•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/19a848c2410c
Comment 3•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/19a848c2410c
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla29
You need to log in
before you can comment on or make changes to this bug.
Description
•