Closed
Bug 958576
Opened 10 years ago
Closed 10 years ago
Move more things into detail namespaces in bindings code
Categories
(Core :: DOM: Core & HTML, defect)
Tracking
()
RESOLVED
FIXED
mozilla29
People
(Reporter: bzbarsky, Assigned: bzbarsky)
Details
(Whiteboard: [qa-])
Attachments
(2 files)
7.33 KB,
patch
|
peterv
:
review+
|
Details | Diff | Splinter Review |
11.40 KB,
patch
|
peterv
:
review+
|
Details | Diff | Splinter Review |
Fast* dictionary types are already there, but I saw people using AutoSequence. And FakeDependentString should really go there as well. Patches coming up.
Assignee | ||
Comment 1•10 years ago
|
||
Note that we can't name this namespace "detail", because then we'd have both ::mozilla::detail and ::mozilla::dom::detail namespaces in the tree and various template name lookups that look for "detail::Foo" would get confused, and the code would not compile. C++ strikes again.
Attachment #8358476 -
Flags: review?(peterv)
Assignee | ||
Comment 2•10 years ago
|
||
We can avoid the include of BindingUtils.h in UnionTypes.h if we move FakeDependentString to a separate header... which we may well want to do, in fact. Let me know?
Attachment #8358480 -
Flags: review?(peterv)
Assignee | ||
Updated•10 years ago
|
Whiteboard: [need review]
Updated•10 years ago
|
Attachment #8358476 -
Flags: review?(peterv) → review+
Comment 3•10 years ago
|
||
Comment on attachment 8358480 [details] [diff] [review] part 2. Move FakeDependentString to the binding_detail namespace. Review of attachment 8358480 [details] [diff] [review]: ----------------------------------------------------------------- ::: dom/bindings/Codegen.py @@ +3646,5 @@ > + conversionCode = ("%s\n" > + "${declName} = &${holderName};" % > + getConversionCode("${holderName}")) > + else: > + declType = "binding_detail::FakeDependentString" Do we want to specialize NonNullHelper for FakeDependentString so that it returns a nsAString?
Attachment #8358480 -
Flags: review?(peterv) → review+
Assignee | ||
Comment 4•10 years ago
|
||
> Do we want to specialize NonNullHelper for FakeDependentString
I tried to, but I get the compiler complaining that my specialization doesn't match any of the function templates. :(
Assignee | ||
Comment 5•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/49bec226f30e https://hg.mozilla.org/integration/mozilla-inbound/rev/2ec09c9a9df1
Flags: in-testsuite-
Whiteboard: [need review]
Target Milestone: --- → mozilla29
Backed this out in https://hg.mozilla.org/integration/mozilla-inbound/rev/ee997698be4a (along with the patch from bug 962605) because one of them seems to have introduced a new permanent failure only on OSX 10.8 m-oth: https://tbpl.mozilla.org/php/getParsedLog.php?id=33415277&tree=Mozilla-Inbound
Assignee | ||
Comment 7•10 years ago
|
||
Try run at https://tbpl.mozilla.org/?tree=Try&rev=ce543907c35b is totally green, so: https://hg.mozilla.org/integration/mozilla-inbound/rev/669c460f673c https://hg.mozilla.org/integration/mozilla-inbound/rev/1ee233ff37f8
Comment 8•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/669c460f673c https://hg.mozilla.org/mozilla-central/rev/1ee233ff37f8
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Updated•10 years ago
|
Whiteboard: [qa-]
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•