Closed Bug 958652 Opened 10 years ago Closed 10 years ago

Make 'test-perf' output the result JSON to a file

Categories

(Firefox OS Graveyard :: General, defect, P1)

defect

Tracking

(b2g-v1.3T fixed)

RESOLVED FIXED
1.3 C2/1.4 S2(17jan)
Tracking Status
b2g-v1.3T --- fixed

People

(Reporter: jgriffin, Assigned: hub)

References

Details

(Keywords: perf, Whiteboard: [c=automation p=1 s= u=tarako])

Attachments

(2 files)

46 bytes, text/x-github-pull-request
julienw
: review+
jgriffin
: feedback+
Details | Review
46 bytes, text/x-github-pull-request
davehunt
: review+
Details | Review
Currently |make test-perf| dumps a JSON structure to stdout, which we want to be able to post to datazilla.  Dumping it to stdout makes this hard, though, because sometimes other things are dumped to stdout as well.  It's better if the JSON structure is saved to a file we can read after |make test-perf| exits.  See bug 840200 for the same request for the original test-perf framework.
Assignee: nobody → hub
Keywords: perf
Priority: -- → P1
Whiteboard: [c=automation p= s= u=tarako]
Status: NEW → ASSIGNED
Whiteboard: [c=automation p= s= u=tarako] → [c=automation p=1 s= u=tarako]
Attached file Pull request
Julien, do you mind reviewing this?

Jonathan, if you |MOZPERFOUT=file.json make test-perf| the output will be sent there (only the JSON)

Thanks !
Attachment #8359614 - Flags: review?(felash)
Attachment #8359614 - Flags: feedback?(jgriffin)
Comment on attachment 8359614 [details] [review]
Pull request

This should unblock us, thanks.

It makes me quite sad that we hack together the output like this in a make file; it's pretty fragile and not very maintainable, but that seems to be a limitation of the marionette JS harness.  :(
Attachment #8359614 - Flags: feedback?(jgriffin) → feedback+
I could actually do without changing the Makefile. But the complexity of the whole thing make it necessary to use env.

Also you can define "MOZPERFOUT" in local.mk.
Comment on attachment 8359614 [details] [review]
Pull request

r=me

there is one nit to fix, and one question to fix if you want but that is not blocking.
Attachment #8359614 - Flags: review?(felash) → review+
Nit addressed and question answered.
Merged.

https://github.com/mozilla-b2g/gaia/commit/86fdc9e2a78dcd0c8644865e46b1f0ab53b95ae4
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Reopen: it doesn't get passed from local.mk as expected.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Attached file Pull request
Attachment #8361232 - Flags: review?(dave.hunt)
Status: REOPENED → ASSIGNED
Attachment #8361232 - Flags: review?(dave.hunt) → review+
https://github.com/mozilla-b2g/gaia/commit/0d2e5af4b78dc68c36a6e1419d67b5da803b7d3a
Status: ASSIGNED → RESOLVED
Closed: 10 years ago10 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.3 C2/1.4 S2(17jan)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: