958660 - [pt-BR] add Bing to the default list of search providers in Firefox

Status: RESOLVED FIXED

(Mozilla Localizations :: pt-BR / Portuguese (Brazil), defect)

Description

[Bryan Clark (DevTools PM) [:clarkbw]]

Hi, can we add Bing to the default list of search providers for the pt-BR locale?  Bing seems to be missing from the list.  Bing should be listed in the search engine list in the 3rd position after Google and Yahoo!.

Thank you!

Comment 1

[Jeferson Hultmann]

Hello,

1) Are you suggesting Bing should be added

or

2) Does Mozilla want Bing to be added (e.g. due to a search partnership)?


1) ==> I'll ask on our l10n list
2) ==> I'll make a patch

Comment 2

[Bryan Clark (DevTools PM) [:clarkbw]]

This is more 2) than 1) but I was wondering if people had tried using recently.  Bing has come a long way since its initial release.

Comment 3

[Joanne Nagel]

Hi Jeferson, have you had a chance to review this?  If the Bing results are comparable than we would ask that they be included in the plugin list as part of our global agreement.  Thanks! Joanne

Comment 4

[Jeferson Hultmann]

I'll work on this when I'll update localization for Firefox 28 (i.e. next few days). Thanks,

Comment 5

[Jeferson Hultmann]

Does this bug include Firefox Metro?

Comment 6

[Joanne Nagel]

Yes, this should include Metro as well.  Thanks for checking!

Comment 7

[Jeferson Hultmann]

Attachment: patch-bing.diff

Add Bing to Firefox desktop/metro/android

Comment 8

[Francesco Lodolo [:flod]]

One comment about the patch: it would be nice to have items in (metro)list.txt in alphabetical order. It would make the diff less readable this once time, but it's definitely easier to maintain and check.

What I'd like to hear is an answer to Joanne's comment

(In reply to Joanne Nagel from comment #3)
> Hi Jeferson, have you had a chance to review this?  If the Bing results are
> comparable than we would ask that they be included in the plugin list as
> part of our global agreement.

Are Bing's results relevant for pt-BR? Is this an addition that improves the value offered to users?

Comment 9

[Jeferson Hultmann]

Attachment: patch-bing.diff

Add Bing to Firefox desktop/metro/android (v2)

Comment 10

[Jeferson Hultmann]

(In reply to Francesco Lodolo [:flod] from comment #8)
> One comment about the patch: it would be nice to have items in
> (metro)list.txt in alphabetical order. It would make the diff less readable
> this once time, but it's definitely easier to maintain and check.
> 

Done.


> Are Bing's results relevant for pt-BR? Is this an addition that improves the
> value offered to users?


My opinion: neither Yahoo nor Bing adds any value to users (I would remove them both).

If you want broader opinions I can ask on our l10n list.

Comment 11

[Joanne Nagel]

If the results are comparable, then allowing users to chose the search provider is the most important value.  We generate a significant amount of traffic to these providers in other regions, so it would be beneficial to do so in this one as well.  In addition, in the interests of sustainability and meeting our global agreements, it is favorable to implement these providers unless the results have a negative impact.

Comment 12

[Reuben Morais [:reuben]]

I agree with Joanne and I don't think including the provider has any negative impact.

Comment 13

[Francesco Lodolo [:flod]]

(In reply to Jeferson Hultmann from comment #10)
> If you want broader opinions I can ask on our l10n list.

Can you please do that? It's already too late for Firefox 27, so we have time and eventually can land it on beta next cycle to release with Firefox 28.

In particular, it would be useful to categorize the feedback you get in:
1) good: adding Bing (or keeping Yahoo) provides a real benefit
2) neutral
3) bad: distracting, bad results, doesn't provide any values, etc.

In particular, for #3 we need to know why people think that.

Comment 14

[Francesco Lodolo [:flod]]

Comment on attachment 8366881 [details] [diff] [review]
patch-bing.diff

Temporarily clearing the review flag

Comment 15

[Joanne Nagel]

We need to view this a different way: unless Bing or Yahoo results are suboptimal, and L10 articulates what those poor results are and we all agree - they should be included in this locale at the next release.

Comment 16

[Francesco Lodolo [:flod]]

Jeferson, any update? We're a bit short on time here if we want to include this change on Beta.

I agree with Joanne that adding more choices is definitely a plus. In my opinion the only blocker would be having bad results, and it doesn't seem to be the case here.

Comment 17

[Jeferson Hultmann]

For the question "Does Bing provide bad results?", the answer is "No".

Comment 18

[Francesco Lodolo [:flod]]

Comment on attachment 8366881 [details] [diff] [review]
patch-bing.diff

Review of attachment 8366881 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks Jeferson.

Please commit this patch to mozilla-beta, mozilla-aurora and l10n-central with a commit message like "Bug 958660 - [pt-BR] add Bing to the default list of search providers in Firefox, r=flod".

Since we're working on beta, you'll need to request a new sign-off and check that everything works as expected, marking the bug as VERIFIED after that.

Comment 19

[Jeferson Hultmann]

http://hg.mozilla.org/releases/l10n/mozilla-aurora/pt-BR/rev/f35413b92679

Now what? More 2 "hg patch" commands would be the easy way out, but it seems like it's not something I'm supposed to do.

Comment 20

[Francesco Lodolo [:flod]]

Patch transplanted on mozilla-beta
http://hg.mozilla.org/releases/l10n/mozilla-beta/pt-BR/rev/f35413b92679

And l10n-central
http://hg.mozilla.org/l10n-central/pt-BR/rev/32e207c90812

In these cases the best solution is to land on mozilla-beta and then merge down to aurora and central. Or you can land the same patch on all repos, or transplant it. If you don't feel comfortable doing this kind of operation, I can do it for you directly next time ;-)

To verify this in the next Beta, you need to request a new sign-off and wait for the next respin. 

Note that there's another bug pending for Yahoo, so you'll need a new sign-off later in the cycle.
I also have one older bug for pt-BR (bug 942758), it could be useful to know if that's a wontfix.

Comment 21

[Jeferson Hultmann]

Thanks! I hope some day these productization files will be moved to mozilla-central, they really don't belong to l10n.