UITour: Add ability to highlight Accounts item within menu panel

RESOLVED FIXED in Firefox 29

Status

()

Firefox
General
P2
normal
RESOLVED FIXED
5 years ago
4 years ago

People

(Reporter: Habber, Assigned: MattN)

Tracking

unspecified
Firefox 29
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(4 attachments)

(Reporter)

Description

5 years ago
When Accounts are added to the Australis menu panel (http://cl.ly/image/231s1Y1C0b0k) we will need the ability to highlight this item as we do for Add-ons and other items within the menu (http://cl.ly/image/2E1x0t1B0N3A). 


Question:
Will Sync be presented as a separate item in the menu panel, or will it be considered part of Accounts in the UI?
(Reporter)

Updated

5 years ago
Flags: needinfo?(zfang)
Blocks: 862998
OS: Mac OS X → All
Hardware: x86 → All
Created attachment 8359654 [details]
Screen Shot 2014-01-14 at 12.14.34 AM.png

I think Sync is one of the services that FF Account can provide, but currently it's the only service we have. So at least for the first stage Sync is FF account. And the current proposal is place account above "customize" as a non-removable item that take up an entire row in the menu panel.
Flags: needinfo?(zfang)
Assignee: nobody → MattN+bmo
Status: NEW → ASSIGNED
Depends on: 957460
Priority: -- → P2
(Reporter)

Comment 2

5 years ago
This is how accounts/sync will be presented in the menu panel. 

Signed in user - https://www.dropbox.com/s/uu2znj2xn1khbxe/Desktop_Custom_Menu_Signed_In.png

Signed out user - https://www.dropbox.com/s/jvtqpr28m353bxh/Desktop_Custom_Menu_Signed_Out.png 



For specific accounts/sync questions contact Ryan Feeley and John Gruen.
Created attachment 8368210 [details] [diff] [review]
Highlight the glyph in the menu panel

mmaslaney said we can do the same as the Customize target and highlight the glyph. The target name already started with "PanelUI-" so the panel auto-opens when annotating.
Attachment #8368210 - Flags: review?(bmcbride)
To test, set the pref identity.fxaccounts.enabled to true and restart.

One thing I just realized is that if a user has non-FxA sync setup and we try to highlight this target, it won't be visible. This may be weird if the messaging on the page relies on it being there. I guess the page will have to checkSyncSetup and only highlight the button if sync is not enabled.

agibson, jbertsch: Will that work for you when we start highlighting this?
Flags: needinfo?(jbertsch)
Flags: needinfo?(agibson)
(In reply to Matthew N. [:MattN] from comment #4)
> To test, set the pref identity.fxaccounts.enabled to true and restart.
> 
> One thing I just realized is that if a user has non-FxA sync setup and we
> try to highlight this target, it won't be visible. This may be weird if the
> messaging on the page relies on it being there. I guess the page will have
> to checkSyncSetup and only highlight the button if sync is not enabled.

when a user already has old sync, can we remove/replace the sync step entirely, to avoid confusion mentioned above? More ideally, we should just not show the new sync button in the menu to old sync users(but that's a separate bug)
(In reply to Zhenshuo Fang (:fang) - Firefox UX Team from comment #5)
> when a user already has old sync, can we remove/replace the sync step
> entirely, to avoid confusion mentioned above? 

Yes, the webpage can do that if they use checkSyncConfiguration and skip the step if sync is setup at all since no user will have new FxA sync upon prior to 29.

> More ideally, we should just
> not show the new sync button in the menu to old sync users(but that's a
> separate bug)

The new sync button already only appears if FxA sync is being used.
Attachment #8368210 - Flags: review?(bmcbride) → review+
We should probably add an option to getConfiguration to get the status of fxaccounts too.
(Reporter)

Comment 8

5 years ago
Created attachment 8368294 [details]
Desktop_Custom_Menu_Signed_In.pdf
(Reporter)

Comment 9

5 years ago
Created attachment 8368295 [details]
Desktop_Custom_Menu_Signed_Out.pdf

Replacing broken links with attachments. 

How 'Signed In' user and 'Not Signed In' user is represented in menu panel.
(In reply to Blair McBride [:Unfocused] from comment #7)
> We should probably add an option to getConfiguration to get the status of
> fxaccounts too.

I thought about it but didn't think it was necessary for the first usage of UITour for Australis so I figured we can handle that when the need arises.
Keywords: checkin-needed
(In reply to Matthew N. [:MattN] from comment #4)
> To test, set the pref identity.fxaccounts.enabled to true and restart.
> 
> One thing I just realized is that if a user has non-FxA sync setup and we
> try to highlight this target, it won't be visible. This may be weird if the
> messaging on the page relies on it being there. I guess the page will have
> to checkSyncSetup and only highlight the button if sync is not enabled.
> 
> agibson, jbertsch: Will that work for you when we start highlighting this?

Thanks, Matt.

I've enabled the preference and can see the "Sign in to Sync" menu panel. The highlight for "accountStatus" doesn't seem to be working yet, but I think I just need to wait for Nightly to update.

As far as checking if sync is already set up, I think using `Mozilla.UITour.getSyncConfiguration` should be fine. We can work out how to deal with the conditional messaging.
Flags: needinfo?(agibson)
(In reply to Zhenshuo Fang (:fang) - Firefox UX Team from comment #5)
> when a user already has old sync, can we remove/replace the sync step
> entirely, to avoid confusion mentioned above? More ideally, we should just
> not show the new sync button in the menu to old sync users(but that's a
> separate bug)

In the interest of time available before this needs to ship, it might be a better option to show some alternative messaging/highlight a different item if the user already has old sync. Removing an entire step of the tour conditionally might be a push in the time we have left.
https://hg.mozilla.org/mozilla-central/rev/54d9feac4e7a
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 29
Clearing needinfo
Flags: needinfo?(jbertsch)
You need to log in before you can comment on or make changes to this bug.