958773 - Don't use js-ctypes in the ril worker

Status: RESOLVED FIXED

(Firefox OS Graveyard :: RIL, defect)

Description

[[:fabrice] Fabrice Desré]

We're using a lot of memory just to get a few properties.

Comment 1

[[:fabrice] Fabrice Desré]

Attachment: ril-no-ctype-worker.patch

Instead I pass the values to the worker in the 'setInitialOptions' command.

I can't run get_about_memory.py right now on my build but I've hit a all time low in b2g RSS with this patch so there's hope it actually helps. If someone could run a real memory report that would be great!

Comment 2

[[:fabrice] Fabrice Desré]

https://hg.mozilla.org/integration/b2g-inbound/rev/5c6a41cf65df

Comment 3

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/5c6a41cf65df

Comment 4

[Vicamo Yang [:vicamo][:vyang]]

I/Gecko   (   45): RIL Worker[0]: Parcel handling threw ReferenceError: netHelpers is not defined
I/Gecko   (   45): readDataCall_v6@resource://gre/modules/ril_worker.js:5836
I/Gecko   (   45): RIL[REQUEST_DATA_CALL_LIST]@resource://gre/modules/ril_worker.js:5866
I/Gecko   (   45): RIL[REQUEST_SETUP_DATA_CALL]@resource://gre/modules/ril_worker.js:5314
I/Gecko   (   45): RIL.handleParcel@resource://gre/modules/ril_worker.js:4949
I/Gecko   (   45): Buf.processParcel@resource://gre/modules/ril_worker.js:152
I/Gecko   (   45): require._tmpModules[":resource://gre/modules/workers/worker_buf.js"]/Buf.processIncoming@blob:78893422-8293-41e8-b462-fa4e991e9b71:536
I/Gecko   (   45): onRILMessage@resource://gre/modules/ril_worker.js:13910

Comment 5

[Ed Morley [:emorley]]

Backed out for:
https://tbpl.mozilla.org/php/getParsedLog.php?id=32939405&tree=B2g-Inbound


https://hg.mozilla.org/mozilla-central/rev/654854b387dd

Comment 6

[Vicamo Yang [:vicamo][:vyang]]

Re-land with no change: https://hg.mozilla.org/integration/b2g-inbound/rev/2aa44fe4b007
Fix is in: https://hg.mozilla.org/integration/b2g-inbound/rev/51f5ff2e6667

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/2aa44fe4b007

Comment 8

[Jason Smith [:jsmith]]

Note - either this bug or bug 934125 broke cell data. See bug 959602.

Comment 9

[Joe Cheng [:jcheng] (please needinfo)]

triage: 1.3T+ for tarako

Comment 10

[[:fabrice] Fabrice Desré]

 https://hg.mozilla.org/releases/mozilla-b2g28_v1_3t/rev/fe40f1795b18