Don't use js-ctypes in the ril worker

RESOLVED FIXED in 1.3 C2/1.4 S2(17jan)

Status

defect
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: fabrice, Assigned: fabrice)

Tracking

unspecified
1.3 C2/1.4 S2(17jan)
All
Gonk (Firefox OS)
Dependency tree / graph

Firefox Tracking Flags

(blocking-b2g:1.3T+, b2g-v1.3T fixed)

Details

Attachments

(1 attachment)

We're using a lot of memory just to get a few properties.
Instead I pass the values to the worker in the 'setInitialOptions' command.

I can't run get_about_memory.py right now on my build but I've hit a all time low in b2g RSS with this patch so there's hope it actually helps. If someone could run a real memory report that would be great!
Assignee: nobody → fabrice
Attachment #8358712 - Flags: review?(vyang)
Attachment #8358712 - Flags: review?(vyang) → review+
https://hg.mozilla.org/mozilla-central/rev/5c6a41cf65df
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.3 C2/1.4 S2(17jan)
I/Gecko   (   45): RIL Worker[0]: Parcel handling threw ReferenceError: netHelpers is not defined
I/Gecko   (   45): readDataCall_v6@resource://gre/modules/ril_worker.js:5836
I/Gecko   (   45): RIL[REQUEST_DATA_CALL_LIST]@resource://gre/modules/ril_worker.js:5866
I/Gecko   (   45): RIL[REQUEST_SETUP_DATA_CALL]@resource://gre/modules/ril_worker.js:5314
I/Gecko   (   45): RIL.handleParcel@resource://gre/modules/ril_worker.js:4949
I/Gecko   (   45): Buf.processParcel@resource://gre/modules/ril_worker.js:152
I/Gecko   (   45): require._tmpModules[":resource://gre/modules/workers/worker_buf.js"]/Buf.processIncoming@blob:78893422-8293-41e8-b462-fa4e991e9b71:536
I/Gecko   (   45): onRILMessage@resource://gre/modules/ril_worker.js:13910
https://hg.mozilla.org/mozilla-central/rev/2aa44fe4b007
Status: REOPENED → RESOLVED
Closed: 6 years ago6 years ago
Resolution: --- → FIXED
Note - either this bug or bug 934125 broke cell data. See bug 959602.
triage: 1.3T+ for tarako
blocking-b2g: --- → 1.3T+
Whiteboard: [tarako][POVB]
You need to log in before you can comment on or make changes to this bug.