De-holder nsIXPConnect::GetWrappedNativePrototype()

RESOLVED FIXED in Firefox 42

Status

()

Core
XPConnect
RESOLVED FIXED
4 years ago
2 years ago

People

(Reporter: mccr8, Assigned: mccr8)

Tracking

Trunk
mozilla42
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox42 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

4 years ago
Once WrapNative is cleared up, that leaves GetWrappedNativePrototype, CreateSandbox and InitClassesWithNewWrappedGlobal.  HoldObject gets left behind as a shim for places that use holders on the heap.  I think that will work out okay.
(Assignee)

Comment 1

2 years ago
Filing separate bugs for each part.
Summary: De-holder nsIXPConnect → De-holder nsIXPConnect::GetWrappedNativePrototype()
(Assignee)

Comment 2

2 years ago
Created attachment 8624955 [details] [diff] [review]
De-holder nsIXPConnect::GetWrappedNativePrototype().

Again, this can wait for a few weeks. This one is a lot smaller than the other one.

try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=b2952db5b7e8
Attachment #8624955 - Flags: review?(gkrizsanits)
(Assignee)

Updated

2 years ago
Assignee: nobody → continuation
Comment on attachment 8624955 [details] [diff] [review]
De-holder nsIXPConnect::GetWrappedNativePrototype().

Review of attachment 8624955 [details] [diff] [review]:
-----------------------------------------------------------------

Same comment about the |in JSMutableHandleObject aRetVal|. If what I suggested does not work out for some reason I'm fine with whatever Bobby or Boris suggests in this case.
Attachment #8624955 - Flags: review?(gkrizsanits)
(Assignee)

Comment 4

2 years ago
Created attachment 8628003 [details] [diff] [review]
De-holder nsIXPConnect::GetWrappedNativePrototype().

static analysis try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=6b11ac68ad31
Attachment #8628003 - Flags: review?(gkrizsanits)
Attachment #8628003 - Flags: review?(gkrizsanits) → review+
Comment on attachment 8628003 [details] [diff] [review]
De-holder nsIXPConnect::GetWrappedNativePrototype().

Review of attachment 8628003 [details] [diff] [review]:
-----------------------------------------------------------------

Sorry I overlooked this one.

::: js/xpconnect/idl/nsIXPConnect.idl
@@ +262,5 @@
>  // For use with the service manager
>  // {CB6593E0-F9B2-11d2-BDD6-000064657374}
>  #define NS_XPCONNECT_CID \
> +{ 0xb91f1eeb, 0x2fe4, 0x44cc, \
> +  { 0x99, 0x83, 0xab, 0xcc, 0x06, 0xd6, 0x9a, 0x94 } }

You don't have to change the CID only the uuid of the interface.

Comment 6

2 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/3a3dfde50685
https://hg.mozilla.org/mozilla-central/rev/3a3dfde50685
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox42: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
(Assignee)

Updated

2 years ago
Attachment #8624955 - Attachment is obsolete: true
You need to log in before you can comment on or make changes to this bug.