958793 - Add 'use strict' to application update

Status: RESOLVED FIXED

(Toolkit :: Application Update, defect)

Description

[Robert Strong (they/them - no direct email)]

While testing the patch in bug 956468 which added 'use strict' to nsUpdateService.js I encountered some test failures. The failures should be diagnosed and 'use strict' added to nsUpdateService.js and other files.

Comment 1

[Robert Strong (they/them - no direct email)]

Note: checked unit_aus_update tests... so far
downloadAndHashCheckMar.js and downloadInterruptedRecovery.js both failed. In the output is the following.
*** AUS:SVC Downloader:_verifyDownload - failed to compute hash of the downloaded update archive

Comment 2

[Robert Strong (they/them - no direct email)]

Attachment: patch in progress

Try push
https://treeherder.mozilla.org/#/jobs?repo=try&revision=6900b177aee1

Comment 3

[Robert Strong (they/them - no direct email)]

Attachment: patch in progress

Comment 4

[Robert Strong (they/them - no direct email)]

Attachment: patch rev1

Comment 5

[Robert Strong (they/them - no direct email)]

Pushed to try
https://treeherder.mozilla.org/#/jobs?repo=try&revision=e30f21be7339

Comment 6

[Robert Strong (they/them - no direct email)]

Comment on attachment 8589255 [details] [diff] [review]
patch rev1

Try run is looking good
https://treeherder.mozilla.org/#/jobs?repo=try&revision=e30f21be7339

Comment 7

[Stephen A Pohl [:spohl]]

Comment on attachment 8589255 [details] [diff] [review]
patch rev1

Review of attachment 8589255 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/mozapps/update/nsUpdateService.js
@@ +616,5 @@
> + */
> +XPCOMUtils.defineLazyGetter(this, "gCanStageUpdatesSession",
> +                            function aus_gCanStageUpdatesSession() {
> +  try {
> +    var updateTestFile = getInstallDirRoot();

nit (since we're touching this): s/var/let/

@@ +1922,5 @@
>     * See nsIPropertyBag.idl
>     */
>    get enumerator() {
>      var properties = [];
> +    for (var p in this._properties) {

nit: s/var/let/

Comment 8

[Robert Strong (they/them - no direct email)]

Attachment: patch - updated to comments

Comment 9

[Robert Strong (they/them - no direct email)]

Pushed to try
https://treeherder.mozilla.org/#/jobs?repo=try&revision=bf263a12b3b4

Comment 10

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/820eb24e50a9

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/820eb24e50a9