958798 - [Shared Themes] Pt. 3 - Move messageHeader.css code to shared/

Status: RESOLVED FIXED

(Thunderbird :: Theme, defect)

Description

[Josiah Bruner [:jsbruner]]

Attachment: Patch.

Same idea as bugs 947657 and 953011.

Sorry about it's length, but could you please review this Richard?

Comment 1

[Richard Marti (:Paenglab)]

Comment on attachment 8358753 [details] [diff] [review]
Patch.

Review of attachment 8358753 [details] [diff] [review]:
-----------------------------------------------------------------

This is looking good and would have a r+ if messageHeader-aero.css also would be included in this patch.

Aside of this there are only small style things I'd like should be changed.

::: mail/themes/osx/jar.mn
@@ +34,3 @@
>    skin/classic/messenger/messageWindow.css                       (mail/messageWindow.css)
>    skin/classic/messenger/messageBody.css                         (mail/messageBody.css)
> +  skin/classic/messenger/webSearch.css                           (mail/webSearch.css)

This is also in one of mine patches :) but no problem, I have to unbitrott my patch anyway after this landing.

::: mail/themes/osx/mail/messageHeader.css
@@ +462,5 @@
>    border: none !important;
>    background-color: transparent;
>  }
>  
>  .headerValue[containsEmail="true"] {

This rule exists in inc file and can be removed.

::: mail/themes/shared/mail/messageHeader.inc.css
@@ +8,5 @@
> +
> +/* ::::: msg header buttons ::::: */
> +
> +.headerContainer
> +{

Please move this brace after the selector.

@@ +12,5 @@
> +{
> +  min-width: 1px;
> +}
> +
> +

A LF to much.

@@ +17,5 @@
> +/* ::::: msg header toolbars ::::: */
> +
> +#expandedHeaderRows > row,
> +#expandedHeader2Rows > row {
> +/* Ensure that the header names and values are aligned with each other. */

Indent by two spaces.

@@ +112,5 @@
> +  background-image: url("chrome://messenger/skin/tagbg.png");
> +  border-radius: 3px;
> +  border-width: 0.5px;
> +  border-style: outset;
> +  text-shadow: 0 1px 0 rgba(238,238,236,0.4); /* Tango Alumninum 1 */

Please space after the commas.

@@ +191,5 @@
> +  padding: 0;
> +  -moz-box-align: baseline;
> +}
> +
> +window[inlinetoolbox] #modefull {

Please move this after the other window[inlinetoolbox] rule (line 69).

@@ +203,5 @@
> +}
> +
> +#header-view-toolbox:-moz-locale-dir(rtl) {
> +  float: left;
> +}
\ No newline at end of file

Please add a LF at the end.

Comment 2

[Josiah Bruner [:jsbruner]]

Attachment: Final Patch.

Addressed review feedback.

Comment 3

[Richard Marti (:Paenglab)]

Comment on attachment 8358984 [details] [diff] [review]
Final Patch.

Review of attachment 8358984 [details] [diff] [review]:
-----------------------------------------------------------------

Yeah, now all looks good. Thanks.

Comment 4

[Josiah Bruner [:jsbruner]]

https://hg.mozilla.org/comm-central/rev/b5728377e9c6