Closed
Bug 958807
Opened 10 years ago
Closed 9 years ago
DiscardTracker::DiscardNow needs to hold the list mutex
Categories
(Core :: Graphics: ImageLib, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: tnikkel, Unassigned)
References
Details
Attachments
(1 file)
|
931 bytes,
patch
|
jdm
:
review+
|
Details | Diff | Splinter Review |
DiscardTracker::DiscardNow modifies the node list. I don't see any reason why it doesn't need to hold the mutex. The best explanation I can come up with is that when the mutex was added in bug 867755 by changeset http://hg.mozilla.org/mozilla-central/rev/68378e8901f3 the main thread asserts were replaced with mutex locking, and because DiscardNow didn't have a main thread assert it was missed.
Attachment #8358777 -
Flags: review?(seth)
|
||
Updated•10 years ago
|
Attachment #8358777 -
Flags: review?(seth) → review+
|
Reporter | |
Comment 1•10 years ago
|
||
Unfortunately this causes a ton of problems. Don't have time to investigate now, will have to come back to this.
|
|
Reporter | |
Comment 2•9 years ago
|
||
DiscardTracker was removed.
Assignee: tnikkel → nobody
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•