Implement backoff protocol for Android FxAccountClient20

NEW
Unassigned

Status

()

P5
normal
5 years ago
5 months ago

People

(Reporter: nalexander, Unassigned)

Tracking

(Blocks: 1 bug)

Firefox Tracking Flags

(Not tracked)

Details

We need to be extra careful to backoff from the auth server when it's under water.

https://github.com/mozilla/fxa-auth-server/blob/master/docs/api.md#backoff-protocol
This ticket tracks parsing the 503 responses from the auth server, and also bubbling the responses up to the application level (login state machine and ultimately sync adapter).
tracking-fennec: --- → 29+
(Reporter)

Updated

5 years ago
Priority: -- → P2
Nick, did this already get done?
Flags: needinfo?(nalexander)
tracking-fennec: 29+ → 30+
(In reply to Richard Newman [:rnewman] from comment #3)
> Nick, did this already get done?

I don't think so.
Flags: needinfo?(nalexander)
In general, we want to obey all backoffs, all the time.  In this case, I believe that the sync adapter mechanism as a whole will back off our syncs so that we won't hammer the auth server at any time (including when it is underwater and asking for backoff).  So this is a correctness ticket that won't have great impact in the wild.
tracking-fennec: 30+ → ---
(In reply to Nick Alexander :nalexander from comment #5)
> In general, we want to obey all backoffs, all the time.  In this case, I
> believe that the sync adapter mechanism as a whole will back off our syncs
> so that we won't hammer the auth server at any time (including when it is
> underwater and asking for backoff).  So this is a correctness ticket that
> won't have great impact in the wild.

This is true for the auth server, but *not* the token and storage servers.  We do back off as needed for token and storage.

Comment 7

2 years ago
To expand on Comment 5, we have pretty strict rate limiting in the client, so this does indeed seem like a correctness ticket that shouldn't have much impact.
Priority: P2 → P5

Updated

a year ago
Product: Android Background Services → Firefox for Android
Re-triaging per https://bugzilla.mozilla.org/show_bug.cgi?id=1473195

Needinfo :susheel if you think this bug should be re-triaged.
You need to log in before you can comment on or make changes to this bug.