Cleanup of tagColors-aero.css

RESOLVED FIXED in Thunderbird 29.0

Status

Thunderbird
Theme
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: Paenglab, Assigned: Paenglab)

Tracking

unspecified
Thunderbird 29.0
All
Windows 7

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

4 years ago
With adding the new explorer treechildren styling in toolkit (bug 855998) and with bug 894552 (removing the rules from messenger-aero.css) where are no !important declarations needed in tagColors-aero.css.
(Assignee)

Comment 1

4 years ago
Created attachment 8358949 [details] [diff] [review]
cleanup

This patch removes the !important and moves, where possible, the color definitions on one line.
Also the no more needed border-color definitions are removed.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #8358949 - Flags: review?(josiah)
Comment on attachment 8358949 [details] [diff] [review]
cleanup

Review of attachment 8358949 [details] [diff] [review]:
-----------------------------------------------------------------

I've assumed you already tested this, but code-wish it looks okay. Removing so many !important rules is always nice, but we should be on the lookout for regressions that we've (possibly) overlooked.

Thanks Richard!
Attachment #8358949 - Flags: review?(josiah) → review+
(Assignee)

Updated

4 years ago
Keywords: checkin-needed
https://hg.mozilla.org/comm-central/rev/b291715d50d3
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 29.0
You need to log in before you can comment on or make changes to this bug.