Closed
Bug 958959
Opened 10 years ago
Closed 10 years ago
Cleanup of tagColors-aero.css
Categories
(Thunderbird :: Theme, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 29.0
People
(Reporter: Paenglab, Assigned: Paenglab)
Details
Attachments
(1 file)
61.68 KB,
patch
|
jsbruner
:
review+
|
Details | Diff | Splinter Review |
With adding the new explorer treechildren styling in toolkit (bug 855998) and with bug 894552 (removing the rules from messenger-aero.css) where are no !important declarations needed in tagColors-aero.css.
Assignee | ||
Comment 1•10 years ago
|
||
This patch removes the !important and moves, where possible, the color definitions on one line. Also the no more needed border-color definitions are removed.
Comment 2•10 years ago
|
||
Comment on attachment 8358949 [details] [diff] [review] cleanup Review of attachment 8358949 [details] [diff] [review]: ----------------------------------------------------------------- I've assumed you already tested this, but code-wish it looks okay. Removing so many !important rules is always nice, but we should be on the lookout for regressions that we've (possibly) overlooked. Thanks Richard!
Attachment #8358949 -
Flags: review?(josiah) → review+
Assignee | ||
Updated•10 years ago
|
Keywords: checkin-needed
Comment 3•10 years ago
|
||
https://hg.mozilla.org/comm-central/rev/b291715d50d3
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 29.0
You need to log in
before you can comment on or make changes to this bug.
Description
•