gVolumeMountLock is declared and never used

RESOLVED FIXED in mozilla29

Status

()

defect
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: rstrong, Assigned: rstrong)

Tracking

unspecified
mozilla29
x86_64
Windows 7
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [qa-])

Attachments

(1 attachment)

Just noticed this.
Posted patch patch rev1Splinter Review
Assignee: nobody → robert.bugzilla
Status: NEW → ASSIGNED
Attachment #8359002 - Flags: review?(netzen)
Attachment #8359002 - Flags: review?(netzen) → review+
Dave, in bug 785124 you added ifdef MOZ_B2G
http://hg.mozilla.org/mozilla-central/rev/82c54850f723#l3.79

Every other check for B2G in this file checks for MOZ_WIDGET_GONK.

I'd like to replace this one instance of ifdef MOZ_B2G with ifdef MOZ_WIDGET_GONK. Make sense?
Flags: needinfo?(dhylands)
Pushed to mozilla-inbound
https://hg.mozilla.org/integration/mozilla-inbound/rev/0ff4998614a4
Flags: in-testsuite-
Target Milestone: --- → mozilla29
https://hg.mozilla.org/mozilla-central/rev/0ff4998614a4
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Yeah - removing gVolumeMountLock looks fine. I have a feeling that it started out as gVolumeMountLock and gSDCardMountLock was what actually got implemented.

Using MOZ_WIDGET_GONK seems like the right thing to be using as well.
Flags: needinfo?(dhylands)
Thanks! I'll take care of that in bug 959341
Whiteboard: [qa-]
You need to log in before you can comment on or make changes to this bug.