Closed
Bug 959004
Opened 10 years ago
Closed 10 years ago
gVolumeMountLock is declared and never used
Categories
(Toolkit :: Application Update, defect)
Tracking
()
RESOLVED
FIXED
mozilla29
People
(Reporter: robert.strong.bugs, Assigned: robert.strong.bugs)
References
Details
(Whiteboard: [qa-])
Attachments
(1 file)
|
878 bytes,
patch
|
bbondy
:
review+
|
Details | Diff | Splinter Review |
Just noticed this.
|
Assignee | |
Comment 1•10 years ago
|
||
Assignee: nobody → robert.bugzilla
Status: NEW → ASSIGNED
Attachment #8359002 -
Flags: review?(netzen)
|
||
Updated•10 years ago
|
Attachment #8359002 -
Flags: review?(netzen) → review+
|
|
Assignee | |
Comment 2•10 years ago
|
||
Dave, in bug 785124 you added ifdef MOZ_B2G http://hg.mozilla.org/mozilla-central/rev/82c54850f723#l3.79 Every other check for B2G in this file checks for MOZ_WIDGET_GONK. I'd like to replace this one instance of ifdef MOZ_B2G with ifdef MOZ_WIDGET_GONK. Make sense?
Flags: needinfo?(dhylands)
|
|
Assignee | |
Comment 3•10 years ago
|
||
Pushed to mozilla-inbound https://hg.mozilla.org/integration/mozilla-inbound/rev/0ff4998614a4
Flags: in-testsuite-
Target Milestone: --- → mozilla29
|
||
Comment 4•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/0ff4998614a4
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
|
||
Comment 5•10 years ago
|
||
Yeah - removing gVolumeMountLock looks fine. I have a feeling that it started out as gVolumeMountLock and gSDCardMountLock was what actually got implemented. Using MOZ_WIDGET_GONK seems like the right thing to be using as well.
Flags: needinfo?(dhylands)
|
|
Assignee | |
Comment 6•10 years ago
|
||
Thanks! I'll take care of that in bug 959341
|
||
Updated•10 years ago
|
Whiteboard: [qa-]
You need to log in
before you can comment on or make changes to this bug.
Description
•