959036 - Decouple rocketbar and utility tray

Status: RESOLVED WORKSFORME

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Kevin Grandon :kgrandon]

Right now rocketbar listens and acts on a lot of the events that the utility tray uses. Unfortunately, to quickly get rocketbar done, we added a bunch of code in utility tray that should not be there. If we can find some way to share the event handling, but keep the code separate that would be good.

Comment 1

[Kevin Grandon :kgrandon]

Alive - I should probably help clean up the mess I created :)

Can you give me some quick hints on what kind of class structure you would like to use for this? Should the events be moved into statusbar.js perhaps?

Comment 2

[(inactive after 6/18) Alive Kuo [:alive]]

(In reply to Kevin Grandon :kgrandon from comment #1)
> Alive - I should probably help clean up the mess I created :)
> 
> Can you give me some quick hints on what kind of class structure you would
> like to use for this? 

It's up to you because I'm still working on the initial draft of system app rewrite,
IMO:
RocketBar.js should deal with touch events on its own.
If this makes conflict with UtilityTray we should visit the spec or the plan.

Pull out the touch event handler out of the utilityTray and let it decide to open UtilityTray or RocketBar or  SettingsDrawer(in the future) should be a most clean plan. But this may result a big change on utility tray.

> Should the events be moved into statusbar.js perhaps?

I'm not sure what's the event you mean here?

Comment 3

[Kevin Grandon :kgrandon]

I believe these two are mostly separate now with some recent rocketbar work. We should be good here.