959050 - Remove some test files from the exclude list of b2g.json that are passing

Status: RESOLVED FIXED

(Testing :: Mochitest, defect)

Comment 1

[Martijn Wargers (dead)]

Attachment: b2g.json.diff

Comment 2

[Martijn Wargers (dead)]

Pushed to try: https://tbpl.mozilla.org/?tree=Try&rev=747f9b34deac
1171 added test passes.

Comment 3

[Ed Morley [:emorley]]

We need to double check none of these intermittently fail - I've retriggered each mochitest job a number of times :-)

Comment 4

[Ed Morley [:emorley]]

Comment on attachment 8359068 [details] [diff] [review]
b2g.json.diff

Review of attachment 8359068 [details] [diff] [review]:
-----------------------------------------------------------------

::: testing/mochitest/b2g.json
@@ -59,5 @@
> -    "content/media/test/test_source_media.html": "",
> -    "content/media/test/test_streams_element_capture.html": "bug 900172 - timeouts",
> -    "content/media/test/test_streams_element_capture_reset.html": "bug 901102",
> -    "content/media/test/test_streams_gc.html": "Value being assigned to HTMLMediaElement.currentTime is not a finite floating-point value",
> -    "content/media/test/test_unseekable.html":"",

Note: the reason it appears the content/media/test/* entries are now passing is that the "content/media/test":"bug 918299" entry near the top is unilaterally disabling that directory and descendants, and so even with all the removals, the tests are not being run. At such point where bug 918299 is fixed and we re-enable that directory, it would be useful to have the specific entries still here to aid with greening up.

Comment 5

[Martijn Wargers (dead)]

(In reply to Ed Morley [:edmorley UTC+0] from comment #3)
> We need to double check none of these intermittently fail - I've retriggered
> each mochitest job a number of times :-)

Yes, I would have done that too. But thanks for the help!

(In reply to Ed Morley [:edmorley UTC+0] from comment #4)
> Note: the reason it appears the content/media/test/* entries are now passing
> is that the "content/media/test":"bug 918299" entry near the top is
> unilaterally disabling that directory and descendants, and so even with all
> the removals, the tests are not being run. At such point where bug 918299 is
> fixed and we re-enable that directory, it would be useful to have the
> specific entries still here to aid with greening up.

Ok, we can leave it in. I'm not sure it's that useful to leave it in, though, that's why I removed it.

Comment 6

[Martijn Wargers (dead)]

Attachment: b2g.json.diff

test_XHR_system.html is failing, so I readded that again.
Also, the content/media/test entries.

Comment 7

[Martijn Wargers (dead)]

Pushed to try again to make sure I didn't make a stupid mistake: https://tbpl.mozilla.org/?tree=Try&rev=548d2095bf83

Comment 8

[Martijn Wargers (dead)]

Bug 959512 is now for test_XHR_system.html failing.

Comment 9

[Ed Morley [:emorley]]

(In reply to Martijn Wargers [:mwargers] (QA) from comment #5)
> Ok, we can leave it in. I'm not sure it's that useful to leave it in,
> though, that's why I removed it.

Ah if it was intentional, happy to defer to you judgement - just didn't know if it had been missed :-)

Comment 10

[Ed Morley [:emorley]]

s/you/your/

Comment 11

[Martijn Wargers (dead)]

2nd try is all green. I don't care much if the content/media/test entries are in or not.

Comment 12

[Ryan VanderMeulen [:RyanVM]]

Bitrotted and doesn't have r+ AFAICT.

Comment 13

[Martijn Wargers (dead)]

Attachment: b2g.json.diff

I had to unbitrot the patch, let me know if you need a try run for this latest patch again.

Comment 14

[Ed Morley [:emorley]]

Comment on attachment 8360170 [details] [diff] [review]
b2g.json.diff

Thank you :-)

Comment 15

[Martijn Wargers (dead)]

The patch is on top of the patch for bug 959512.

Comment 16

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/b2g-inbound/rev/4ac41b56f578

Comment 17

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/4ac41b56f578