959107 - TypeError: conn.setRoamingPreference is not a function

Status: RESOLVED FIXED

(Firefox OS Graveyard :: RIL, defect)

Description

[Florin Strugariu [:Bebe]]

22:34:01     INFO -  ======================================================================
22:34:01     INFO -  ERROR: None
22:34:01     INFO -  ----------------------------------------------------------------------
22:34:01     INFO -  Traceback (most recent call last):
22:34:01     INFO -    File "/builds/slave/test/build/venv/local/lib/python2.7/site-packages/marionette/marionette_test.py", line 127, in run
22:34:01     INFO -      self.setUp()
22:34:01     INFO -    File "/builds/slave/test/gaia/tests/python/gaia-ui-tests/gaiatest/gaia_test.py", line 855, in setUp
22:34:01     INFO -      self.cleanup_gaia(full_reset=False)
22:34:01     INFO -    File "/builds/slave/test/gaia/tests/python/gaia-ui-tests/gaiatest/gaia_test.py", line 874, in cleanup_gaia
22:34:01     INFO -      self.data_layer.set_setting("keyboard.ftu.enabled", False)
22:34:01     INFO -    File "/builds/slave/test/gaia/tests/python/gaia-ui-tests/gaiatest/gaia_test.py", line 216, in set_setting
22:34:01     INFO -      result = self.marionette.execute_async_script('return GaiaDataLayer.setSetting("%s", %s)' % (name, value), special_powers=True)
22:34:01     INFO -    File "/builds/slave/test/build/venv/local/lib/python2.7/site-packages/marionette/marionette.py", line 1089, in execute_async_script
22:34:01     INFO -      filename=os.path.basename(frame[0]))
22:34:01     INFO -    File "/builds/slave/test/build/venv/local/lib/python2.7/site-packages/marionette/marionette.py", line 593, in _send_message
22:34:01     INFO -      self._handle_error(response)
22:34:01     INFO -    File "/builds/slave/test/build/venv/local/lib/python2.7/site-packages/marionette/marionette.py", line 628, in _handle_error
22:34:01    ERROR -      raise JavascriptException(message=message, status=status, stacktrace=stacktrace)
22:34:01    ERROR -  JavascriptException: TypeError: conn.setRoamingPreference is not a function
22:34:01     INFO -  	stacktrace:
22:34:01     INFO -  	@app://system.gaiamobile.org/js/telephony_settings.js, line 36
22:34:01     INFO -  TEST-UNEXPECTED-FAIL | test_settings.py test_settings.TestSettings.test_set_named_setting |

Comment 1

[Florin Strugariu [:Bebe]]

The TBPL build is:
https://tbpl.mozilla.org/php/getParsedLog.php?id=32905482&tree=B2g-Inbound

Comment 2

[Zac C (:zac)]

This is not to do with the Settings app; it's just a exception in the start up that coincides with this test.

Kevin, this seems very similar to Bug 956012, is it related?

Comment 3

[Kevin Grandon :kgrandon]

This is kind of another thing where we don't have the local shims. While the code should probably guard against this case, updating the shim is super easy - and will allow us to have a cleaner desktop dev environment. I'll go ahead and update the shims quickly.

Comment 4

[Kevin Grandon :kgrandon]

Attachment: Github pull request

This one is easy enough, and generally not part of our build. I will probably review it.

Comment 5

[Kevin Grandon :kgrandon]

Comment on attachment 8359273 [details] [review]
Github pull request

Not part of the build, and simple developer tooling fix. This error message was also present in our Firefox Developer Environment, and this solves it. R=me.

Comment 6

[Kevin Grandon :kgrandon]

Landed in master: https://github.com/mozilla-b2g/gaia/commit/5e8ab97e8be4f67053d6c5b20ee18508f2749b92

Please let me know if this doesn't fix the issue.