959156 - Jit-test basic\bug839215.js OOMs on Windows test machines

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Dan Minor [:dminor]]

On opt builds, this test appears to run out of memory:

09:19:39  WARNING -  TEST-UNEXPECTED-FAIL | tests\jit-test\jit-test\tests\basic\bug839215.js |
09:19:39     INFO -  INFO exit-status     : 3
09:19:39     INFO -  INFO timed-out       : False
09:19:39     INFO -  INFO stdout          >
09:19:39     INFO -  INFO stderr         2> uncaught exception: out of memory
09:19:39     INFO -  INFO stderr         2>

Comment 1

[Dan Minor [:dminor]]

This test looks like this:
var b = new ArrayBuffer(10000000000);
var dv = new DataView(b);

Changing the array length from 10000000000 to 500000000 will cause the test to pass on the Windows XP test machines, but that is 20x smaller and I imagine that changes the intention of the test.

Comment 2

[Dan Minor [:dminor]]

On the most recent Cedar run, it looks like this also fails on Windows 7 test machines, so failures on both XP and 7 for both opt and debug builds.

Terrence, do you know, or know who to ask, if changing the array length is an acceptable fix for this?

Comment 3

[Terrence Cole [:terrence]]

For such a simple test, if the problem recurs the fuzzers will find it again almost instantly. It's not worth it too keep in the regression suite if it is causing headaches. Please just |hg rm js\src\jit-test\tests\basic\bug839215.js| and mark bug 839215 as in-testsuite-.

Comment 4

[Dan Minor [:dminor]]

Attachment: Remove the offending test

Comment 5

[Terrence Cole [:terrence]]

Comment on attachment 8361894 [details] [diff] [review]
Remove the offending test

Review of attachment 8361894 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks! r=me

Comment 6

[Dan Minor [:dminor]]

Thanks, pushed to https://hg.mozilla.org/integration/mozilla-inbound/rev/450458fa68ee

Comment 7

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/450458fa68ee