Closed
Bug 959156
Opened 10 years ago
Closed 10 years ago
Jit-test basic\bug839215.js OOMs on Windows test machines
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
FIXED
mozilla29
People
(Reporter: dminor, Assigned: dminor)
References
Details
Attachments
(1 file)
534 bytes,
patch
|
terrence
:
review+
|
Details | Diff | Splinter Review |
On opt builds, this test appears to run out of memory: 09:19:39 WARNING - TEST-UNEXPECTED-FAIL | tests\jit-test\jit-test\tests\basic\bug839215.js | 09:19:39 INFO - INFO exit-status : 3 09:19:39 INFO - INFO timed-out : False 09:19:39 INFO - INFO stdout > 09:19:39 INFO - INFO stderr 2> uncaught exception: out of memory 09:19:39 INFO - INFO stderr 2>
Assignee | ||
Comment 1•10 years ago
|
||
This test looks like this: var b = new ArrayBuffer(10000000000); var dv = new DataView(b); Changing the array length from 10000000000 to 500000000 will cause the test to pass on the Windows XP test machines, but that is 20x smaller and I imagine that changes the intention of the test.
Assignee | ||
Comment 2•10 years ago
|
||
On the most recent Cedar run, it looks like this also fails on Windows 7 test machines, so failures on both XP and 7 for both opt and debug builds. Terrence, do you know, or know who to ask, if changing the array length is an acceptable fix for this?
Flags: needinfo?(terrence)
Summary: Jit-test basic\bug839215.js OOMs on Windows XP test machines → Jit-test basic\bug839215.js OOMs on Windows test machines
Comment 3•10 years ago
|
||
For such a simple test, if the problem recurs the fuzzers will find it again almost instantly. It's not worth it too keep in the regression suite if it is causing headaches. Please just |hg rm js\src\jit-test\tests\basic\bug839215.js| and mark bug 839215 as in-testsuite-.
Flags: needinfo?(terrence)
Assignee | ||
Comment 4•10 years ago
|
||
Comment 5•10 years ago
|
||
Comment on attachment 8361894 [details] [diff] [review] Remove the offending test Review of attachment 8361894 [details] [diff] [review]: ----------------------------------------------------------------- Thanks! r=me
Attachment #8361894 -
Flags: review?(terrence) → review+
Assignee | ||
Comment 6•10 years ago
|
||
Thanks, pushed to https://hg.mozilla.org/integration/mozilla-inbound/rev/450458fa68ee
Comment 7•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/450458fa68ee
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla29
You need to log in
before you can comment on or make changes to this bug.
Description
•