Closed
Bug 959164
Opened 10 years ago
Closed 10 years ago
Jit-test basic\bug710947.js fails on Windows 8 test machines
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
FIXED
mozilla29
People
(Reporter: dminor, Assigned: dminor)
References
Details
Attachments
(1 file)
707 bytes,
patch
|
terrence
:
review+
|
Details | Diff | Splinter Review |
This test fails on Cedar for Windows 8 (debug): Appears to timeout: WARNING - TEST-UNEXPECTED-FAIL | tests\jit-test\jit-test\tests\basic\bug710947.js | --ion-eager --ion-parallel-compile=off --ion-check-range-analysis --no-sse3 10:04:11 INFO - INFO exit-status : -1 10:04:11 INFO - INFO timed-out : True 10:04:11 INFO - INFO stdout > 10:04:11 INFO - INFO stderr 2> 10:04:11 INFO - TIMEOUT - basic\bug710947.js
Assignee | ||
Comment 1•10 years ago
|
||
Like bug 959156 this one uses a large ArrayBuffer that is causing problems on the Windows test machines: // |jit-test| allow-oom; function startTest() { if (typeof document != "object" || !document.location.href.match(/jsreftest.html/)) {} }; gczeal(4); startTest(); ArrayBuffer( 946684800000 ); Can we just remove this one from the testsuite as well? It seems like an intermittent timeout rather than an OOM, so possibly this needs further investigation.
Flags: needinfo?(terrence)
Comment 2•10 years ago
|
||
Unlike the previous test, this is catching a fairly subtle regression. I think any sized allocation larger than 16 * sizeof(Value) should work to trigger it. If we change the last line to |ArrayBuffer( 8192 );| does that fix the timeout?
Flags: needinfo?(terrence)
Assignee | ||
Comment 3•10 years ago
|
||
I ran this on the loaner test machine and on try and this seems to fix the problem. Try run is here: https://tbpl.mozilla.org/?tree=Try&rev=da83119b547b&showall=1 Thanks for the suggestion!
Comment 4•10 years ago
|
||
Comment on attachment 8367890 [details] [diff] [review] Change ArrayBuffer size to make windows tests machines happy. Review of attachment 8367890 [details] [diff] [review]: ----------------------------------------------------------------- Great! r=me
Attachment #8367890 -
Flags: review?(terrence) → review+
Assignee | ||
Comment 5•10 years ago
|
||
Thanks, pushed to https://hg.mozilla.org/integration/mozilla-inbound/rev/a535989de2b9
Comment 6•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/a535989de2b9
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla29
You need to log in
before you can comment on or make changes to this bug.
Description
•