959175 - Force redrawing on uppercase-switching for Layouts with secondLayout set to true. Regression after 875963

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Keyboard, defect)

Description

[Ahmed Nefzaoui [:Nefzaoui]]

It seems like since after bug 875963, Layouts with secondLayout set to true are not being able to user the uppercase layout as a second view for the rest of the characters.
The perfect solution would be to force redrawing uppercase whenever we have secondLayout in a locale's layout
secondLayout was suggested in bug 942651

Comment 1

[Jan Jongboom [:janjongboom] (inactive)]

Attachment: Patch

Fairly straightforward. We shouldn't do this behavior checking in render.js, so I moved that to keyboard.js and re-introduced the uppercase flag in render again. Now all logic is in keyboard.js, and the rendering in render.js. With tests around it.

Comment 2

[Ahmed Nefzaoui [:Nefzaoui]]

Comment on attachment 8359830 [details] [review]
Patch

Works like a charm :)

Comment 3

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Comment on attachment 8359830 [details] [review]
Patch

r=me.

It was my fault that did not catch this at the beginning.

Jan, Ahmed, thanks for your help to make it right.

Comment 4

[Jan Jongboom [:janjongboom] (inactive)]

Good reason why we should increase our test coverage :-)

Landed in https://github.com/mozilla-b2g/gaia/commit/e553ba3a0cdf9b4bfaa4d946279e31a0eacb2806.

Comment 5

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Uplifted to v1.3t,
https://github.com/mozilla-b2g/gaia/commit/9bd921d1b6b67a4903466de333d7c2f98a0d5cca