959227 - Revert UITest changes introduced in bug 929388

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Fernando Jiménez Moreno [:ferjm]]

The tests won't pass until bug 929386 lands

Comment 1

[Fernando Jiménez Moreno [:ferjm]]

Attachment: Pull Request

Comment 2

[Zac C (:zac)]

Ferjm I'm missing the context for this change.
Does this revert only the changes to the UI test app from bug 929388, and UI test/Persona will still work?

Then after bug 929386 you will re-submit the UI test changes?

Comment 3

[Fernando Jiménez Moreno [:ferjm]]

(In reply to Zac C (:zac) from comment #2)
> Ferjm I'm missing the context for this change.

Sorry about that, I should have explained it in a better way.

> Does this revert only the changes to the UI test app from bug 929388, and UI
> test/Persona will still work?
> 

Yes, this patch only reverts the changes introduced in the UI test app from bug 929388. It was suggested during the review not to include them, but it was finally landed this way. The tests won't pass the way they are now until bug 929386, so I thought about reverting the change, so the Persona tests can keep working as usual.

> Then after bug 929386 you will re-submit the UI test changes?

Yes, once bug 929386 lands, the tests will be reviewed and landed again.

Thanks Zac!

Comment 4

[Zac C (:zac)]

Thanks Fernando,

We'll also get the test re-enabled in Travis so you know it's safe when you commit bug 929386.

Comment 5

[Zac C (:zac)]

Comment on attachment 8359326 [details] [review]
Pull Request

Both tests run fine on desktopb2g.
thanks

We'll work in a separate bug to enable this on Travis again.

Comment 6

[Zac C (:zac)]

Merged:
https://github.com/mozilla-b2g/gaia/commit/c94e915148877bd0b625730f0fd4aa6e99540769