959275 - Custom devtools is logging telemetry information

Status: RESOLVED FIXED

(DevTools :: General, defect)

Description

[Kevin Grandon :kgrandon]

In gaia we have a custom profile which registers a devtool in an extension. The following error is being logged:

Warning: An attempt was made to open a tool with an id of "firefox-os-controls", which is not listed in Telemetry._histograms. Location: telemetry.js/toolOpened()

Relevant code: http://mxr.mozilla.org/mozilla-central/source/browser/devtools/shared/telemetry.js#173

Comment 1

[Joe Walker [:jwalker]]

(In reply to Kevin Grandon :kgrandon from comment #0)
> In gaia we have a custom profile which registers a devtool in an extension.
> The following error is being logged:
> 
> Warning: An attempt was made to open a tool with an id of
> "firefox-os-controls", which is not listed in Telemetry._histograms.
> Location: telemetry.js/toolOpened()
> 
> Relevant code:
> http://mxr.mozilla.org/mozilla-central/source/browser/devtools/shared/
> telemetry.js#173

Mike, who would normally deal with this, is on PTO this week and next. I looks at a brief skim like this is just a warning message, and not blocking you. Is that right?

Comment 2

[Kevin Grandon :kgrandon]

I missed that. This is only a debug message, and not a blocker, though we would like to clean this up a bit.

Comment 3

[Kevin Grandon :kgrandon]

Attachment: Potential-patch-add-custom-devtool-telemetry.patch

Comment 4

[Kevin Grandon :kgrandon]

Comment on attachment 8372963 [details] [diff] [review]
Potential-patch-add-custom-devtool-telemetry.patch

Review of attachment 8372963 [details] [diff] [review]:
-----------------------------------------------------------------

Hey - guys, wondering if you have some time to review this. Currently we allow developers to create their own devtool panels (which is something we do in gaia), but when you click on it telemetry errors get logged. This pull request makes it so that we handle custom devtool panels if we can't find a telementry entry for the panel. Alternatively we could just remove the error being logged, and return silently.

Comment 5

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Comment on attachment 8372963 [details] [diff] [review]
Potential-patch-add-custom-devtool-telemetry.patch

Review of attachment 8372963 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me, r+.

Comment 6

[Kevin Grandon :kgrandon]

Attachment: 0001-Bug-959275-Add-telemetry-support-for-custom-dev-tool.patch

Updating patch description /w review.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/fx-team/rev/8a9dbcf18c62

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/8a9dbcf18c62