959286 - Defaulting track event values doesn't happen if object has a property set to undefined

Status: VERIFIED FIXED

(Webmaker Graveyard :: Popcorn Maker, defect)

Description

[Scott [:thecount] Downe]

Right now on staging YouTube clips being opened in the editor crashes.

We try to access contentType which is expected to be a string with the content type, or defaulted to "".

Actually though, it's undefined, and it misses the defaulting.

We check if something needs to be defaulted by doing "!popcornOptions.hasOwnProperty( prop )"

This is going to fail if at some point we did this:

options.contentType: getContentType() // returns undefined

so now even though options,contentType is not defined, there is a contentType property there, so it never gets defaulted.

We should instead be doing a double equal check against null. This way we don't default false, 0 and "", but we do default undefined, no prop and null.

Patch done, just need a bug number.

Comment 1

[Scott [:thecount] Downe]

Attachment: https://github.com/mozilla/popcorn.webmaker.org/pull/410

Comment 2

[Matthew Schranz [:mjschranz]]

Comment on attachment 8359329 [details] [review]
https://github.com/mozilla/popcorn.webmaker.org/pull/410

See comments.

Comment 3

[Scott [:thecount] Downe]

Comment on attachment 8359329 [details] [review]
https://github.com/mozilla/popcorn.webmaker.org/pull/410

Updates.

Comment 4

[Scott [:thecount] Downe]

Also added line comments in the pull to explain the changes. Might not be obvious.

Comment 5

[Scott [:thecount] Downe]

Staged: https://github.com/mozilla/popcorn.webmaker.org/commit/ec9de2b2cd7ab19b4b3c52a33e93bcf86913e107

Needs verification.