Closed
Bug 95929
Opened 23 years ago
Closed 23 years ago
`Done.' should not be present in Subscribe status
Categories
(SeaMonkey :: MailNews: Message Display, defect)
SeaMonkey
MailNews: Message Display
Tracking
(Not tracked)
VERIFIED
FIXED
mozilla0.9.9
People
(Reporter: mpt, Assigned: stephend)
References
()
Details
(Keywords: polish)
Attachments
(1 file)
1.29 KB,
patch
|
stephend
:
review+
sspitzer
:
superreview+
|
Details | Diff | Splinter Review |
Build: 2001081704, Mac OS 9.1 To reproduce: 1. Open the Subscribe dialog for a news server, for the first time with a new profile. 2. Wait for the group list to load, then look at the status bar. What you see: * `Done.' What you should see: * Nothing.
Assignee | ||
Comment 1•23 years ago
|
||
re-assigning to Seth.
Assignee: stephend → sspitzer
OS: Mac System 9.x → All
Hardware: Macintosh → All
Assignee | ||
Comment 2•23 years ago
|
||
According to the spec, it should be there. Jennifer, comments?
Comment 3•23 years ago
|
||
I think the spec should be changed then, because "Done." doesn't really say anything. It's just as worthless as the "Document Done (X secs)" we have in Navigator (yes, there's a bug filed on that).
Spec can be changed if folks feel that is more appropriate. So user opens the dialog, newsgroups are retrieved, status of retrieval is shown in status bar during process. Loading is completed. 1. Display "Download complete" or something similar. Remove status text as soon as the user clicks on something. 2. Once download is completed, remove all text from the status bar. mpt, you don't think its useful to inform the user the download has completed? Even briefly?
Reporter | ||
Comment 5•23 years ago
|
||
Yes, the end of newsgroup loading should be indicated by the spinning arrows disappearing, as we do currently when loading a sidebar. But there should not be any `Done' text: that makes it look like a status bar, which (since it's not a document window) it should not have.
Assignee | ||
Comment 6•23 years ago
|
||
I've been asked to mass-check bugs with no TM and priority, as to their validity. This bug still exits on the latest trunk.
Comment 7•23 years ago
|
||
Nominating for 1.0. I decided I would try out some newsgroups for the first time just now. The 'Done' looks extremely awkward. It was one of the first things I noticed because it is so out of place. For all I knew, Mozilla was 'Done' subscribing me to a bunch of newsgroups because I selected an option to 'Subscribe to Newsgroups' and the title of the window I opened was labeled 'Subscribe'. Telling me 'Done' implies that I am done with my selected action of Subscribing which is a negative impression. When I am done I will click OK. I also expect nothing to appear. When the cursor stops spinning, I know that the groups are downloaded.
Assignee | ||
Comment 9•23 years ago
|
||
Removes the string in the properties, passes null to the showStatusFeedback method.
Comment 10•23 years ago
|
||
Comment on attachment 66024 [details] [diff] [review] Patch V1.0 assuming this is what jglick wants, and that "doneString" isn't used anywhere else, sr=sspitzer when I originally added that code, I was copying what 4.x did. but I think the reason 4.x did that was because of how the old netlib worked. (in 4.x, the status text has "Document: Done" when done downloading the list.) thanks for the fix stephend.
Attachment #66024 -
Flags: superreview+
Assignee | ||
Updated•23 years ago
|
Target Milestone: --- → mozilla0.9.9
Assignee | ||
Comment 11•23 years ago
|
||
Comment on attachment 66024 [details] [diff] [review] Patch V1.0 Hi Stephen, This is fine with me. Thanks. (sorry for delay, offsite last week) Jen
Attachment #66024 -
Flags: review+
Assignee | ||
Comment 12•23 years ago
|
||
Fixed. Re-setting QA to Ninoschka (because I made the fix). If this belongs to Karen instead, please re-assign. Thanks.
Status: NEW → RESOLVED
Closed: 23 years ago
QA Contact: stephend → nbaca
Resolution: --- → FIXED
Comment 13•23 years ago
|
||
Verified Fixed. When it's downloading the newsgroups in the Subscribe dialog it states "Please wait". When all the newsgroups are listed then it states nothing.
Status: RESOLVED → VERIFIED
Updated•20 years ago
|
Product: Browser → Seamonkey
Component: MailNews: Subscribe → MailNews: Message Display
QA Contact: nbaca → search
You need to log in
before you can comment on or make changes to this bug.
Description
•