959334 - Invoking js_InitTypedObjectModuleObject or js_InitSIMDClass in GlobalObject::initStandardClasses causes mochitest-plain to fail

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Bobby Holley (:bholley)]

In bug 959013, I'm cleaning up GlobalObject::initStandardClasses so that it just iterates over the proto keys and invokes all the initializers as appropriate. In doing so, I appear to have broken mochitest-plain. I narrowed it down, and it appears that js_InitTypedObjectModuleObject gets invoked where it didn't before. Apparently we currently do lazy resolution, but eager resolution breaks somehow.

Niko is going to take a look.

Comment 1

[Bobby Holley (:bholley)]

Also happens with js_InitSIMDClass.

Comment 2

[Niko Matsakis [:nmatsakis]]

Attachment: Bug959334.diff

Since SIMD also invokes this class, this will likely address that case too, though I guess it merits review to make sure we didn't make a similar mistake there.

Comment 3

[Bobby Holley (:bholley)]

I've got this in a patch queue that I'll be landing shortly. I'll land this along with it, unless anyone objects.

Comment 4

[Niko Matsakis [:nmatsakis]]

I have no objection.

Comment 5

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/a44f13894eb0