959341 - Replace MOZ_B2G with MOZ_WIDGET_GONK

Status: RESOLVED FIXED

(Toolkit :: Application Update, defect)

Description

[Robert Strong (they/them - no direct email)]

There is only one instance of MOZ_B2G and many instances of MOZ_WIDGET_GONK in nsUpdateService.js. In bug 959004 I received confirmation that we should use MOZ_WIDGET_GONK instead of MOZ_B2G.

Comment 1

[Robert Strong (they/them - no direct email)]

Attachment: patch

Comment 2

[Brian R. Bondy [:bbondy]]

Comment on attachment 8359396 [details] [diff] [review]
patch

Review of attachment 8359396 [details] [diff] [review]:
-----------------------------------------------------------------

I think maybe MOZ_B2G is defined everywhere for B2G including emulators, and GONK is only defined when using GONK widget subsystem, but I don't feel comfortable with the difference in regards to updates.  Also that's just my understanding about which is used where and I'm not confident about that either.
Forwarding to someone who may know better than me.

I don't see any problems with this, but I can't judge well enough myself.

Comment 3

[Dave Hylands [:dhylands]]

Comment on attachment 8359396 [details] [diff] [review]
patch

Review of attachment 8359396 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me.

MOZ_WIDGET_GONK is defined anywhere that B2G interacts with Android. Which is on physical devices and under the emulator. This does not include desktop B2G, or the simulator (and updating doesn't apply there), or any desktop version of firefox.

Comment 4

[Robert Strong (they/them - no direct email)]

Pushed to mozilla-inbound
https://hg.mozilla.org/integration/mozilla-inbound/rev/7f8407ca38a1

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/7f8407ca38a1