dynamic duration changes can bust track event ends and starts

VERIFIED FIXED

Status

Webmaker
Popcorn Maker
VERIFIED FIXED
4 years ago
4 years ago

People

(Reporter: thecount, Assigned: thecount)

Tracking

Details

(Assignee)

Description

4 years ago
No idea yet what is causing this.

STRS:

1. Add a clip that fills the duration.
2. play it to the end.
3. seek back into it.

Expected: should start again.
Actual: it's stuck in ended.

I also saw a crash when I tried to change the duration while the clip was there but only worked locally.

I'll try to get strs for that.
(Assignee)

Updated

4 years ago
Assignee: nobody → scott
(Assignee)

Comment 1

4 years ago
It is fine now.

Might of been something on YouTube's end.

Closing for now.
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → INVALID
(Assignee)

Comment 2

4 years ago
Hm, hit this again today.
Status: RESOLVED → REOPENED
Resolution: INVALID → ---
(Assignee)

Comment 3

4 years ago
Not limited to YouTube.

new STRS:

1. Load up a fresh empty project.
2. Increase the project's duration.
3. Add a text event.
4. Fill the project duration with the text event.
5. Seek to near the end.
6. Hit play, and play until you hit the end of the project.
7. Seek back into the project, to see the text event.

Expected: A text event should show up.
Actual: Nothing.

I think the key here is the duration change.
Summary: youtube clip errors → dynamic duration changes can bust track event ends and starts
(Assignee)

Comment 4

4 years ago
Staged:

https://github.com/mozilla/popcorn.webmaker.org/commit/1fa5e566e419c9cde6f4630283a5eeaf00d3d678
https://github.com/mozilla/popcorn-js/commit/65a2629b7bd31cff10f09495ba5367e007f7782d

Needs verification.
Status: REOPENED → RESOLVED
Last Resolved: 4 years ago4 years ago
Flags: needinfo?(scott)
Resolution: --- → FIXED
(Assignee)

Updated

4 years ago
Status: RESOLVED → VERIFIED
Flags: needinfo?(scott)
You need to log in before you can comment on or make changes to this bug.