959413 - Convert Components members to smart pointers

Status: RESOLVED FIXED

(Core :: XPConnect, defect)

Description

[Bobby Holley (:bholley)]

Per bug 951948 comment 22. We have a lot of stuff like |NS_IF_RELEASE(mException;| that we should fix up.

Comment 1

[Andrew McCreight [:mccr8]]

Pretty straight forward.

Comment 2

[Bobby Holley (:bholley)]

(note that this should probably wait for bug 951948 to land)

Comment 3

[Andrew McCreight [:mccr8]]

https://tbpl.mozilla.org/?tree=Try&rev=5646ed8743fb

Comment 4

[Andrew McCreight [:mccr8]]

Attachment: part 1 - Remove null checks of new return values in XPC_IMPL_GET_OBJ_METHOD.

You looked at this recently, Bobby, so I'll give these to you to review, and
my other stuff later I'll give to Gabor.

Comment 5

[Andrew McCreight [:mccr8]]

Attachment: part 2 - Smart pointerize nsXPCComponents.

Comment 6

[Andrew McCreight [:mccr8]]

Attachment: part 3 - Smart pointerize nsXPCConstructor.

Comment 7

[Andrew McCreight [:mccr8]]

Attachment: part 4 - Get rid of a pointless null check in nsXPCComponents_Constructor.

Comment 8

[Bobby Holley (:bholley)]

Comment on attachment 8360661 [details] [diff] [review]
part 4 - Get rid of a pointless null check in nsXPCComponents_Constructor.

Review of attachment 8360661 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for all this great cleanup Andrew.

Comment 9

[Andrew McCreight [:mccr8]]

remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/ff6ceb188610
remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/ea0e905d918d
remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/7ee640392376
remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/e9cc6569386e

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/ff6ceb188610
https://hg.mozilla.org/mozilla-central/rev/ea0e905d918d
https://hg.mozilla.org/mozilla-central/rev/7ee640392376
https://hg.mozilla.org/mozilla-central/rev/e9cc6569386e