Closed Bug 959420 Opened 6 years ago Closed 6 years ago

Refactor saveApps, getManifestFor, readManifests, writeFile functions to use promises

Categories

(Core Graveyard :: DOM: Apps, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla29

People

(Reporter: marco, Assigned: marco)

References

Details

(Whiteboard: [qa-])

Attachments

(2 files)

A first step for bug 801610. I'd like to split it into several bugs and land the patches progressively because otherwise I have to continuosly rebase my work (as the modifications are spread across the file).

This refactors some functions in Webapps.jsm to use promises and in some cases OS.File.

In the startup path we can't yet use OS.File because of timing issues (using OS.File, that is slower, the tests start before the b2g system application is loaded).
Attached patch PatchSplinter Review
Assignee: nobody → mar.castelluccio
Status: NEW → ASSIGNED
Attachment #8359524 - Flags: review?(fabrice)
Comment on attachment 8359524 [details] [diff] [review]
Patch

Review of attachment 8359524 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm. Do you have a try run?

::: dom/apps/src/Webapps.jsm
@@ +317,3 @@
>    },
>  
> +  updatePermissionsForApp: function(aId) {

I would rather do the "remove functions names" in another patch. That doesn't help with tracking what's going on in this patch.
Attachment #8359524 - Flags: review?(fabrice) → review+
Attached patch followupfixSplinter Review
This fixes the last usage of saveApps just introduced in bug 757226.
Attachment #8361400 - Flags: review?(fabrice)
Attachment #8361400 - Flags: review?(fabrice) → review+
https://hg.mozilla.org/mozilla-central/rev/75a010e3f038
https://hg.mozilla.org/mozilla-central/rev/f363dae6a41c
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla29
Depends on: 962273
Depends on: 962229
Depends on: 961762
Depends on: 966988
Whiteboard: [qa-]
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.