add lldb summaries for nsAString and nsACString

RESOLVED FIXED in mozilla29

Status

()

Core
General
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: heycam, Assigned: heycam)

Tracking

Trunk
mozilla29
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [qa-])

Attachments

(1 attachment)

Created attachment 8359585 [details] [diff] [review]
patch
Attachment #8359585 - Flags: review?(ehsan)

Comment 1

4 years ago
Comment on attachment 8359585 [details] [diff] [review]
patch

Review of attachment 8359585 [details] [diff] [review]:
-----------------------------------------------------------------

::: python/lldbutils/lldbutils/general.py
@@ +3,5 @@
> +
> +def summarize_string(valobj, internal_dict):
> +    data = valobj.GetChildMemberWithName("mData")
> +    length = valobj.GetChildMemberWithName("mLength").GetValueAsUnsigned(0)
> +    return utils.format_string(data, min(length, 100))

Again, I don't think we should clamp the string.
Attachment #8359585 - Flags: review?(ehsan) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/cd6c3a4beacd

Comment 3

4 years ago
https://hg.mozilla.org/mozilla-central/rev/cd6c3a4beacd
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla29

Updated

4 years ago
Whiteboard: [qa-]
You need to log in before you can comment on or make changes to this bug.