Closed Bug 959461 Opened 10 years ago Closed 9 years ago

Create telemetry module

Categories

(Add-on SDK Graveyard :: General, defect, P2)

Product:
Add-on SDK Graveyard
Component:
General
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: evold, Unassigned)

References

Details

Attachments

(1 file)

Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/1347
358 bytes, text/html
irakli
: review+
Details
Assignee: nobody → evold
Attachment #8360053 - Flags: review?(rFobic)
Hey Nathan, I'm wondering if you know if there would be some advantage to the Jetpack (Add-on SDK) team listing our histograms in this json file instead of dynamically creating the histogram with an add-on id like "jetpack-sdk@mozilla.com" ?

Or perhaps you might know who would have the answer.
Flags: needinfo?(nfroyd)
(In reply to Erik Vold [:erikvold] [:ztatic] from comment #2)
> Hey Nathan, I'm wondering if you know if there would be some advantage to
> the Jetpack (Add-on SDK) team listing our histograms in this json file
> instead of dynamically creating the histogram with an add-on id like
> "jetpack-sdk@mozilla.com" ?

Sorry, I totally missed responding to your earlier inquiry!

If you know all the histograms you are interested in ahead of time, then the biggest advantage would be viewing them on the telemetry dashboard.  I don't think we have anything for viewing add-on histograms currently.

But it looks like the SDK stuff lets you create new histograms dynamically, so defining them in Histograms.json would be a non-starter.  What you have right now is the only route forward.
Flags: needinfo?(nfroyd)
(In reply to Nathan Froyd (:froydnj) from comment #3)
> (In reply to Erik Vold [:erikvold] [:ztatic] from comment #2)
> > Hey Nathan, I'm wondering if you know if there would be some advantage to
> > the Jetpack (Add-on SDK) team listing our histograms in this json file
> > instead of dynamically creating the histogram with an add-on id like
> > "jetpack-sdk@mozilla.com" ?
> 
> Sorry, I totally missed responding to your earlier inquiry!
> 
> If you know all the histograms you are interested in ahead of time, then the
> biggest advantage would be viewing them on the telemetry dashboard.  I don't
> think we have anything for viewing add-on histograms currently.
> 
> But it looks like the SDK stuff lets you create new histograms dynamically,
> so defining them in Histograms.json would be a non-starter.  What you have
> right now is the only route forward.

Hmm I'm not sure how one can visualize the data for a dynamically added telemetry historgram, is there some documentation or example of this that I have missed that you know about?

I went over http://telemetry.mozilla.org/docs.html#Telemetry but am still confused how to get the aggregate data for the dynamically added add-on histograms.
Flags: needinfo?(nfroyd)
(In reply to Erik Vold [:erikvold] [:ztatic] from comment #4)
> Hmm I'm not sure how one can visualize the data for a dynamically added
> telemetry historgram, is there some documentation or example of this that I
> have missed that you know about?

Not that I know of.

> I went over http://telemetry.mozilla.org/docs.html#Telemetry but am still
> confused how to get the aggregate data for the dynamically added add-on
> histograms.

I don't see anything there for viewing add-on histograms.  I think you may be the very first user of addon histograms, so there are likely some growing pains.  Filing a telemetry server bug for adding the appropriate API bits is the right way forward.
Flags: needinfo?(nfroyd)
(In reply to Nathan Froyd (:froydnj) from comment #5)
> (In reply to Erik Vold [:erikvold] [:ztatic] from comment #4)
> > Hmm I'm not sure how one can visualize the data for a dynamically added
> > telemetry historgram, is there some documentation or example of this that I
> > have missed that you know about?
> 
> Not that I know of.
> 
> > I went over http://telemetry.mozilla.org/docs.html#Telemetry but am still
> > confused how to get the aggregate data for the dynamically added add-on
> > histograms.
> 
> I don't see anything there for viewing add-on histograms.  I think you may
> be the very first user of addon histograms, so there are likely some growing
> pains.  Filing a telemetry server bug for adding the appropriate API bits is
> the right way forward.

Ahh that makes sense :) will do.
(In reply to Nathan Froyd (:froydnj) from comment #5)
> (In reply to Erik Vold [:erikvold] [:ztatic] from comment #4)
> > I went over http://telemetry.mozilla.org/docs.html#Telemetry but am still
> > confused how to get the aggregate data for the dynamically added add-on
> > histograms.
> 
> I don't see anything there for viewing add-on histograms.  I think you may
> be the very first user of addon histograms, so there are likely some growing
> pains.  Filing a telemetry server bug for adding the appropriate API bits is
> the right way forward.

Hmm where do I file these Telemetry bugs?
Comment on attachment 8360053 [details]
Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/1347

Erik, I feel like there a several onion layers for no good reason. Have you considered exposing this stuff as a part of console API ? Maybe this is worth
discussing at work week with other devtoolers since console is under their control now ?
Attachment #8360053 - Flags: review?(rFobic) → review-
I also think registration maybe done under the hood whenever user does first telemetry API call.
(In reply to Irakli Gozalishvili [:irakli] [:gozala] [@gozala] from comment #8)
> Comment on attachment 8360053 [details]
> Pointer to Github pull request:
> https://github.com/mozilla/addon-sdk/pull/1347
> 
> Erik, I feel like there a several onion layers for no good reason. Have you
> considered exposing this stuff as a part of console API ? Maybe this is worth
> discussing at work week with other devtoolers since console is under their
> control now ?

why would this be part of the console api?
Flags: needinfo?(rFobic)
(In reply to Irakli Gozalishvili [:irakli] [:gozala] [@gozala] from comment #9)
> I also think registration maybe done under the hood whenever user does first
> telemetry API call.

As far as I understand, one has to get a histogram by id to "make a call" (ie add data to the histogram) and you cannot get a histogram that has not been registered.  It's like a DOM element, the DOM doesn't create a element under the hood with all of the desired attributes when using document.getElementById(), the element has to be manually added first, with the desired attributes.
Comment on attachment 8360053 [details]
Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/1347

Re-opening review request!
Attachment #8360053 - Flags: review- → review?(rFobic)
Flags: needinfo?(rFobic)
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
No idea why this got closed.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Hey Irakli, I've been waiting for almost a year now for a review here, and Honza was asking for something like this during the work week.
Flags: needinfo?(rFobic)
Hey Irakli, you mentioned last week that you wanted to talk about this, please let me know when you are ready to I am free anytime.
I'm unassigning myself from this, it takes too long to get feedback.
Assignee: evold → nobody
I apologize it never got enough high enough on my priority list. How about you request feedback from honza and if he's happy I'm happy to go through with it as a low level API & we can improve it if that will be necessary. 

Alternatively you could just publish this to npm I think.
Flags: needinfo?(rFobic)
(In reply to Irakli Gozalishvili [:irakli] [:gozala] [@gozala] from comment #17)
> I apologize it never got enough high enough on my priority list. How about
> you request feedback from honza and if he's happy I'm happy to go through
> with it as a low level API & we can improve it if that will be necessary. 

I'm not sure Honza will understand this, it's low level telemetry code, Irving Reid would have been the guy to get feedback from, but he's not with Mozilla any longer.  I don't know who we can help with this anymore atm.

Also I wanted this to record differences in the json l10n module versus the properties l10n implementation, but now I think it will take too long to get the data that I will need to make changes before releasing JPM 1.0,

It will still be very useful to have this data, but now I am overloaded with work now, and I don't have the energy to drive this anymore.
Flags: needinfo?(odvarko)
I am overloaded by work too, so no time for this. Btw. Firebug is already using the platform API, registering a histogram and measuring the custom theme usage. The problem I am solving is how to access the online data uploaded by users.

Honza
Flags: needinfo?(odvarko)
(In reply to Jan Honza Odvarko [:Honza] from comment #19)
> I am overloaded by work too, so no time for this. Btw. Firebug is already
> using the platform API, registering a histogram and measuring the custom
> theme usage. The problem I am solving is how to access the online data
> uploaded by users.

Ya I know that part is not easy, especially if you use the add-on api, since Firebug may be the first add-on to collect telemetry.

I wanted to tackle the graphing of data, after I collected data for the sdk, which is blocked by this bug.
Status: REOPENED → RESOLVED
Closed: 10 years ago → 9 years ago
Resolution: --- → FIXED
Attachment #8360053 - Flags: review?(rFobic) → review+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: