959480 - add lldb summaries for nsTArray and nsAutoTArray

Status: RESOLVED FIXED

(Core :: General, defect)

Description

[Cameron McCormack (:heycam)]

Attachment: patch

Comment 1

[(no longer active)]

Comment on attachment 8359606 [details] [diff] [review]
patch

Review of attachment 8359606 [details] [diff] [review]:
-----------------------------------------------------------------

I assume this handles empty arrays as well?

::: python/lldbutils/lldbutils/general.py
@@ +36,5 @@
>  def init(debugger):
>      debugger.HandleCommand("type summary add nsAString_internal -F lldbutils.general.summarize_string")
>      debugger.HandleCommand("type summary add nsACString_internal -F lldbutils.general.summarize_string")
> +    debugger.HandleCommand("type synthetic add -x \"nsTArray<\" -l lldbutils.general.TArraySyntheticChildrenProvider")
> +    debugger.HandleCommand("type synthetic add -x \"nsAutoTArray<\" -l lldbutils.general.TArraySyntheticChildrenProvider")

Please handle FallibleTArray as well.

Comment 2

[Cameron McCormack (:heycam)]

(In reply to :Ehsan Akhgari (needinfo? me!) from comment #1)
> I assume this handles empty arrays as well?

Yeah they get shown as "{}" when printed.

Comment 3

[Cameron McCormack (:heycam)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/def1c895cd80

Comment 4

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/def1c895cd80