Landscape mode for data/time picker

NEW
Assigned to

Status

Firefox OS
Gaia::System
4 years ago
3 days ago

People

(Reporter: rudyl, Assigned: Pas, Mentored, NeedInfo)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [good first bug][lang=css][mentor-lang=zh])

Attachments

(2 attachments)

From this card in trello, I found we have a design for landscape mode of date/time picker and the general value selector.
https://trello.com/c/KeY47a5X/94-ui-component-adaptation-for-landscape

However, need the confirmed visual design so that we could implement the landscape mode for these general control components.

Will open related bugs and make this a meta bug if there are too much work to do here.
Hi Eric,

I heard from Patryk, that you could provide the detailed design for common controls?
Let me know if I should redirect this to someone else.
Thanks.
Flags: needinfo?(epang)
(In reply to Rudy Lu [:rudyl] from comment #1)
> Hi Eric,
> 
> I heard from Patryk, that you could provide the detailed design for common
> controls?
> Let me know if I should redirect this to someone else.
> Thanks.

Hi Rudy, what is the landscape date time picker for?  Which device, which apps?
AFAIK we don't use landscape mode for it on the phone.

Thanks!
Eric
Flags: needinfo?(epang) → needinfo?(rlu)
Created attachment 8360893 [details]
screenshot for date picker in landscape mode

Hi Eric,

Since <input type="date"> or <input type="time"> is a common usage on web, and our browser app allows landscape mode, we could see this issue on plain web.

Please refer to the screenshot for an example.
Let me know if you have any other questions.
Flags: needinfo?(rlu)
Flags: needinfo?(epang)
Created attachment 8362946 [details]
Time_Picker.jpg

Hi Rudy, I looked on trello.  Can we use the specs that Sergi provided?
Flags: needinfo?(epang) → needinfo?(rlu)
Hi Eric,

Yes for sure if you think the design by Sergi is ok.
Flags: needinfo?(rlu)
I guess the changes for this bug should be mostly CSS, so mark this as good first bug.
Whiteboard: [good first bug][mentor=RudyL][lang=css][mentor-lang=zh]

Comment 7

4 years ago
I am interested in working on this bug.  Can I be assigned to it ?
Assignee: nobody → aksht.kedia
Flags: needinfo?(rlu)
Hi Akshat,

Sure.

Please note that the value selector we're talking about here lives in Gaia system app.
Please let me know if you need more guidance on how to resolve this issue.

Thanks.
Flags: needinfo?(rlu)

Comment 9

4 years ago
https://developer.mozilla.org/en-US/Firefox_OS/Using_the_B2G_desktop_client
I dont have a Firefox OS phone. Can this be used for testing bugs and changes ?
Flags: needinfo?(rlu)
Yes, and you could even use Firefox browser to run Gaia, so you will get all the developer tools working,
https://developer.mozilla.org/en-US/Firefox_OS/Using_Gaia_in_Firefox

BTW, after a 2nd thought, this might need some changes in JS as well, just a soft reminder.
Thanks.
Flags: needinfo?(rlu)

Comment 11

4 years ago
Sorry for the late reply, I was super busy with university. Can you tell me which part of the codebase I need to work on. I can't find the date picker in gaia/apps/system.
Flags: needinfo?(rlu)
For time picker, it is in,
https://github.com/mozilla-b2g/gaia/blob/master/apps/system/js/value_selector/value_selector.js

For date picker, it is in the above and another separate file,
https://github.com/mozilla-b2g/gaia/blob/master/apps/system/js/value_selector/spin_date_picker.js

Thanks for your interest.
Flags: needinfo?(rlu)

Comment 13

4 years ago
Hello there. I'm not sure if Akshat is still working on this bug, but if he is not, I would love to contribute.
Flags: needinfo?(rlu)
I am not sure, either. Let's ni him.

Akshat,

Are you still working on this?


--
Thanks for your interest in contributing to Firefox OS.
Flags: needinfo?(rlu) → needinfo?(aksht.kedia)

Comment 15

4 years ago
Hey,

I am sorry for not updating here. I am not really working on the bug right now. Anyone can go ahead with the bug.
Flags: needinfo?(aksht.kedia)
Akshat, thank you.

Then, I'll assign to loganallc since he is interested to take a look.
Assignee: aksht.kedia → loganallc
Mentor: rlu@mozilla.com
Whiteboard: [good first bug][mentor=RudyL][lang=css][mentor-lang=zh] → [good first bug][lang=css][mentor-lang=zh]

Comment 17

4 years ago
Hi , can I help in this bug? I am new so I may need assistance!
Julio, I'm flagging Rudy (the mentor for this bug - he has offered to provide assistance on this)
Flags: needinfo?(rlu)
loganallc,

May I know if you're still working on this bug?
If not, maybe Julio could take a look.

Julio,

Thanks for your interest, let's see how loganallc responds.
Flags: needinfo?(rlu) → needinfo?(loganallc)
Hey guys,

Do you know if loganallc is working on this or I can take a look?

Thanks

Comment 21

3 years ago
It doesn't look like Loganallc is still working on this; last touch from them was 2 months ago. 

I'm deassigning it. croitoruradubogdan - are you still interested in pursuing this? We'd love for you to pick it up.
Assignee: loganallc → nobody
Flags: needinfo?(loganallc) → needinfo?(croitoruradubogdan)
Sure, I wanna try to fix this :). Thanks Mike
Flags: needinfo?(croitoruradubogdan)

Comment 23

3 years ago
Great. Run with it, and if you've got any questions, ask them here. Rudy will be able to help.

Comment 24

3 years ago
Anyone working on this bug?

Comment 25

3 years ago
Hi, I'm new here and would like to help fixing this bug. Rudy Lu please assign to me this bug.

Thanks!
Hi, I was out of town and this bug was assigned to me 3 days ago. Can someone assign it so we can know who's working on it? It's not a contest..

Comment 27

3 years ago
Hi croitoruradubogdan, sorry, did not know that was assigned to you, because not in the description of the bug. Thank you for helping Mozilla community.
Assign this to Radu-Bogdan based on comment 22.
Assignee: nobody → croitoruradubogdan
(Assignee)

Comment 29

2 years ago
Hi, I am new to fixing bugs and I would like to work on the bug please.

Comment 30

2 years ago
Ok, Pas, we haven't seen any movement on this in a while so I'm going to reassign this to you. Let me know if you've got any questions, please use the "needinfo" checkbox at the bottom of the bug or email me directly.
Assignee: croitoruradubogdan → obipascal
(Assignee)

Comment 31

2 years ago
Please where

Comment 32

11 months ago
Hi, I am new to bug fixing and this would be my first bug ever. I would like to work on this. Thanks.
Flags: needinfo?(left.lu)

Comment 33

3 days ago
I'm a student from coventry university studying an opensource module, I would like to be assigned this as my first bug! Could you please point me in the right direction of how to start
You need to log in before you can comment on or make changes to this bug.