959501 - [Media Encoder] Add preferences for video encoder

Status: RESOLVED FIXED

(Core :: Audio/Video: Recording, defect)

Description

[Randy Lin [:rlin] - Be Mozillian on 2015/01/26]

The video recording is a new support feature, 
IHMO to have preference to disable this by default.
And make it default on if we catch as much bugs as we can.

Comment 1

[Randy Lin [:rlin] - Be Mozillian on 2015/01/26]

Attachment: patch v1

Comment 2

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 8359641 [details] [diff] [review]
patch v1

Review of attachment 8359641 [details] [diff] [review]:
-----------------------------------------------------------------

::: modules/libpref/src/init/all.js
@@ +275,5 @@
> +#ifdef MOZ_WEBM_ENCODER
> +pref("media.encoder.webm.enabled", false);
> +#endif
> +#ifdef MOZ_OMX_ENCODER
> +pref("media.encoder.omx.enabled", false);

I think these should be true by default.

Comment 3

[Randy Lin [:rlin] - Be Mozillian on 2015/01/26]

Attachment: patch v2

OK. Let's rocks.

Comment 4

[Shelly Lin [:shelly]]

http://dxr.mozilla.org/mozilla-central/source/content/media/encoder/MediaEncoder.cpp#123

Because the source video of test case is not .ogg and neither the track type contains ContainerWriter::HAS_AUDIO.

Comment 5

[Shelly Lin [:shelly]]

I meant to comment in Bug 957439................

Comment 6

[Randy Lin [:rlin] - Be Mozillian on 2015/01/26]

Attachment: check-in patch

check-in patch, try result
https://tbpl.mozilla.org/?tree=Try&rev=2955d95c507a

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/b2g-inbound/rev/c557f12208a4

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/c557f12208a4