Remove EXTERNALLY_MANAGED_MAKE_FILE traversal

RESOLVED FIXED in mozilla29

Status

RESOLVED FIXED
5 years ago
8 months ago

People

(Reporter: glandium, Assigned: glandium)

Tracking

Trunk
mozilla29
x86_64
Linux
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [qa-])

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
EXTERNALLY_MANAGED_MAKE_FILE traversal was used for gyp, but now gyp directories are handled as if they had a moz.build, so they don't need specific traversal rules. The exception in config.mk, however, is still needed for bug 952120 and config/tests/src-simple/Makefile.in.
(Assignee)

Comment 1

5 years ago
Created attachment 8359653 [details] [diff] [review]
Remove EXTERNALLY_MANAGED_MAKE_FILE traversal
Attachment #8359653 - Flags: review?(gps)
(Assignee)

Updated

5 years ago
Assignee: nobody → mh+mozilla
Status: NEW → ASSIGNED
Vaguely recall a patch checked in that uses this for extension built with SeaMonkey (using mc build system. Cc to confirm
(Assignee)

Comment 3

5 years ago
(In reply to Justin Wood (:Callek) from comment #2)
> Vaguely recall a patch checked in that uses this for extension built with
> SeaMonkey (using mc build system. Cc to confirm

See comment 0, that was bug 952120, and it's not using what i'm removing.
(Assignee)

Updated

5 years ago
Blocks: 958404

Updated

5 years ago
Attachment #8359653 - Flags: review?(gps) → review+
https://hg.mozilla.org/mozilla-central/rev/b528de4b776f
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla29

Updated

5 years ago
Whiteboard: [qa-]

Updated

8 months ago
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.