Closed Bug 959570 Opened 6 years ago Closed 6 years ago

Don't draw rounded corners and a highlight line in fullscreen mode

Categories

(Core :: Widget: Cocoa, defect)

All
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla29

People

(Reporter: mstange, Assigned: mstange)

Details

Attachments

(1 file)

Attached patch v1Splinter Review
With Australis, since we draw the titlebar ourselves, we also draw the highlight line at the top of the window on top of everything. Even during fullscreen video! You can see this on http://www.videojs.com/ when playing the video and switching it to fullscreen - there's a white line at the very top of the screen.

I think we should just turn off the window decorations in fullscreen mode. The attached patch does that.
Attachment #8359772 - Flags: review?(smichaud)
Comment on attachment 8359772 [details] [diff] [review]
v1

This looks fine to me, but I do have one nit:

+enum {
+   NSFullScreenWindowMask = 1 << 14
+};

This should probably be wrapped in

#if !defined(MAC_OS_X_VERSION_10_7) || MAC_OS_X_VERSION_MAX_ALLOWED < MAC_OS_X_VERSION_10_7
#endif
Attachment #8359772 - Flags: review?(smichaud) → review+
Comment on attachment 8359772 [details] [diff] [review]
v1

Forget about my nit.  I just realized that enum is already inside a
#if !defined(MAC_OS_X_VERSION_10_7) || MAC_OS_X_VERSION_MAX_ALLOWED < MAC_OS_X_VERSION_10_7
block.
https://hg.mozilla.org/mozilla-central/rev/6bf3e0350c4a
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla29
You need to log in before you can comment on or make changes to this bug.