Implement custom styling for the awesomebar suggestion of the search provider

RESOLVED INVALID

Status

()

Firefox
Search
RESOLVED INVALID
5 years ago
4 years ago

People

(Reporter: phlsa, Assigned: Neil Deakin)

Tracking

(Blocks: 1 bug)

28 Branch
x86
All
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Whiteboard: p=2

Updated

5 years ago
Whiteboard: p=2 → [feature] p=2

Updated

4 years ago
Whiteboard: [feature] p=2 → [feature] p=2 [qa+]

Updated

4 years ago
Whiteboard: [feature] p=2 [qa+] → [search] p=2 [qa+]

Updated

4 years ago
Status: NEW → ASSIGNED
Whiteboard: [search] p=2 [qa+] → [search] p=5 s=it-30c-29a-28b.3 [qa+]

Updated

4 years ago
Assignee: nobody → enndeakin
QA Contact: petruta.rasa
(Assignee)

Comment 1

4 years ago
Please provide some context for this bug.
When I pinged Bryan on IRC, he pointed to Philipp's mockup:

http://phlsa.github.io/ff-search-suggestion/

That looks like pretty much the existing autocomplete styling, so maybe there's nothing to actually do here.

Philipp, any other thoughts?
Flags: needinfo?(philipp)
(In reply to :Gavin Sharp (email gavin@gavinsharp.com) from comment #2)
> When I pinged Bryan on IRC, he pointed to Philipp's mockup:
> 
> http://phlsa.github.io/ff-search-suggestion/
> 
> That looks like pretty much the existing autocomplete styling, so maybe
> there's nothing to actually do here.
> 
> Philipp, any other thoughts?

Yes, I think there's not that much to do here other than making sure the favicon and text are shown and styled properly.

Since we are currently making a lot of changes to the location bar, I'd suggest a general visual overhaul if this in the near future (so that our users actually *see* things are improving), but that isn't in the scope of this bug.
Flags: needinfo?(philipp)

Updated

4 years ago
Whiteboard: [search] p=5 s=it-30c-29a-28b.3 [qa+] → [search] p=5 [qa+]
I don't think this is actionable until we actually have those results in autocomplete (bug 959573), that bug will take a while (I think a full 2 weeks iteration) cause I want to make an experimental patch that refactors autocomplete and inline complete in a single query, as it was originally.
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → INVALID

Updated

4 years ago
Whiteboard: [search] p=5 [qa+] → [search] p=0

Updated

4 years ago
No longer blocks: 950073
Whiteboard: [search] p=0
You need to log in before you can comment on or make changes to this bug.