959619 - Add tag suggestions to popcorn tag input

Status: RESOLVED FIXED

(Webmaker Graveyard :: Popcorn Maker, defect)

Comment 1

[Chris DeCairos (:cade)]

Add tag suggestions as the user types in the tag input box using the Tag Autocomplete API
See: https://github.com/mozilla/makeapi-client/blob/master/src/make-api.js#L438-L446 
and See: https://github.com/mozilla/makeapi#get-api20130724maketags

Comment 2

[Chris DeCairos (:cade)]

Attachment: https://github.com/mozilla/popcorn.webmaker.org/pull/426

This patch updates jQuery to 1.10.2 and adds typeahead.js for autocomplete support.

Comment 3

[Matthew Schranz [:mjschranz]]

Kate can review UI, but look at my comments.

Comment 4

[Chris DeCairos (:cade)]

(In reply to Matthew Schranz [:mjschranz] from comment #3)
> Kate can review UI, but look at my comments.

took care of the comments. updating jquery doesn't appear to have broken anything. I tested as many features as I could - drag'n'drop, resizing, plugins, publishing, project details, plugin editing, trac event area, etc.

Comment 5

[inactivate account for kate]

Comment on attachment 8364406 [details] [review]
https://github.com/mozilla/popcorn.webmaker.org/pull/426

UI looks fine to me

Comment 6

[Chris DeCairos (:cade)]

Comment on attachment 8364406 [details] [review]
https://github.com/mozilla/popcorn.webmaker.org/pull/426

I re-wrote this to use jquery-ui autocomplete instead of twitter's typeahead.js.

It's a smaller patch now - and has less stuff we don't need.

Comment 7

[inactivate account for kate]

Comment on attachment 8364406 [details] [review]
https://github.com/mozilla/popcorn.webmaker.org/pull/426

This is definitely better, just try not to add that theme file in

Comment 8

[Chris DeCairos (:cade)]

Comment on attachment 8364406 [details] [review]
https://github.com/mozilla/popcorn.webmaker.org/pull/426

All fixed up!

Comment 9

[inactivate account for kate]

Comment on attachment 8364406 [details] [review]
https://github.com/mozilla/popcorn.webmaker.org/pull/426

remove typeahead

Comment 10

[[github robot]]

Commit pushed to master at https://github.com/mozilla/popcorn.webmaker.org

https://github.com/mozilla/popcorn.webmaker.org/commit/923837da604a2f8bba2c50dc50ce2bf6649a7f1d
bug 959619 - Implement tag suggestions