Closed
Bug 959621
Opened 11 years ago
Closed 11 years ago
Add tag suggestions to thimble's tag input
Categories
(Webmaker Graveyard :: Thimble, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: cade, Assigned: cade)
References
Details
Attachments
(1 file)
No description provided.
Assignee | ||
Comment 1•11 years ago
|
||
Add tag suggestions as the user types in the tag input box using the Tag Autocomplete API
See: https://github.com/mozilla/makeapi-client/blob/master/src/make-api.js#L438-L446
and See: https://github.com/mozilla/makeapi#get-api20130724maketags
Assignee: nobody → cade
Assignee | ||
Comment 2•11 years ago
|
||
This patch updates jQuery in Friendlycode to version 1.10.2 in order to support the use of Twitter's typahead.js library (requires 1.9.0+).
I've as many features as I could and the upgrade doesn't appear to have any negative effects.
Attachment #8363693 -
Flags: review?
Assignee | ||
Updated•11 years ago
|
Attachment #8363693 -
Flags: review? → review?(kate)
Comment 3•11 years ago
|
||
Comment on attachment 8363693 [details] [review]
Enable tag suggestions on tag input boxes using the MakeAPI
I noticed that if you type part of a word, then arrow down and press enter to add something in the autocompletion menu, after the tag gets added, the autocompletion doesn't go away (it should). One nit also in the css. Other than that, this is good
Attachment #8363693 -
Flags: review?(kate) → review+
Assignee | ||
Comment 4•11 years ago
|
||
Comment on attachment 8363693 [details] [review]
Enable tag suggestions on tag input boxes using the MakeAPI
I ran into a whole bunch of issues with the autocomplete lib I chose for the original patch. I made the call to switch to the jQuery-ui autocomplete widget. This allowed me to leave the version of jQuery we already use the same, and gave me some more control over events. It also has the added benefit of not being really hard to style!
Attachment #8363693 -
Flags: review+ → review?(kate)
Comment 5•11 years ago
|
||
Comment on attachment 8363693 [details] [review]
Enable tag suggestions on tag input boxes using the MakeAPI
Just fix up that one font stack thing
Attachment #8363693 -
Flags: review?(kate) → review+
Assignee | ||
Comment 6•11 years ago
|
||
Merged: https://github.com/cadecairos/thimble.webmaker.org/commit/c404b0291e97c406a94aafd639dd03d76285e353
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•