959672 - Use correct model name for Hamachi device

Status: RESOLVED FIXED

(Testing Graveyard :: Eideticker, defect)

Description

[Dave Hunt [:davehunt] [he/him] ⌚BST]

For a recent Hamachi mozilla-central build I am getting a different model name. It's "ALCATEL ONE TOUCH FIRE" instead of "msm7627a".

application_buildid: 20140113040202
application_changeset: 12d3ba62a599
application_name: B2G
application_repository: http://hg.mozilla.org/mozilla-central
application_version: 29.0a1
device_firmware_date: 1380051975
device_firmware_version_incremental: 139
device_firmware_version_release: 4.0.4
device_id: msm7627a
gaia_changeset: fd3b9a97cb3c41cfa56be387b46a51db136b4422
gaia_date: 1389610832
platform_buildid: 20140113040202
platform_changeset: 12d3ba62a599
platform_repository: http://hg.mozilla.org/mozilla-central

Comment 1

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Attachment: Use correct model name for Hamachi device. v1.0

Comment 2

[William Lachance (:wlach)]

Comment on attachment 8359870 [details] [diff] [review]
Use correct model name for Hamachi device. v1.0

Review of attachment 8359870 [details] [diff] [review]:
-----------------------------------------------------------------

I think this will break backwards compatibility for older Hamachi builds. I think we should just clone the model's old property dictionary, give it the new name, and add it to the list.

(r+ assuming we do this instead)

Comment 3

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Landed as:
https://github.com/mozilla/eideticker/commit/93db2858b749f1fce80f0ce6b59716e98f392a7d