959676 - Properly parse and support embed style URLs in the app

Status: VERIFIED FIXED

(Webmaker Graveyard :: Popcorn Maker, enhancement)

Description

[David Humphrey (:humph)]

This is a bit of an edge case, but it would be nice if PM knew how to deal with embed URLs (i.e., what you'd put in <iframe src=...>.  NOTE: I'm not suggesting we switch to expecting this type of URL; only that we do the right thing if we're given one.

* YouTube

ttps://www.youtube.com/embed/CLg2JbELs9o?feature=youtube_gdata&rel=0&modestbranding=1&iv_load_policy=3&showinfo=0&origin=https%3A%2F%2Fpopcorn.webmaker.org&controls=0&wmode=opaque&enablejsapi=1

Here we need the video ID, CLg2JbELs9o

* Vimeo

https://player.vimeo.com/video/46353153?api=1&player_id=1389718102887&title=0&byline=0&portrait=0&butteruid=1389717725429

Here we need the id video/46353153

* SoundCloud

https://w.soundcloud.com/player/?url=https://api.soundcloud.com/tracks/11921587&show_artwork=false&buying=false&liking=false&sharing=false&download=false&show_comments=false&show_user=false&single_active=false

We need the tracks/11921587 bit out of the query string here

Comment 1

[Scott [:thecount] Downe]

Attachment: https://github.com/mozilla/popcorn.webmaker.org/pull/411

Comment 2

[David Humphrey (:humph)]

Comment on attachment 8359922 [details] [review]
https://github.com/mozilla/popcorn.webmaker.org/pull/411

I think Matt is a better candidate reviewer for this.

Comment 3

[Matthew Schranz [:mjschranz]]

Comment on attachment 8359922 [details] [review]
https://github.com/mozilla/popcorn.webmaker.org/pull/411

Minor lint fails.

Also, if I use that example Vimeo URL, copy what it adds to the source and try to add that url as media it doesn't detect it as the same media already added and will let me add it again. YouTube/SoundCloud are fine in these regards.

Comment 4

[Scott [:thecount] Downe]

Comment on attachment 8359922 [details] [review]
https://github.com/mozilla/popcorn.webmaker.org/pull/411

Updated

Comment 5

[Scott [:thecount] Downe]

Staged: https://github.com/mozilla/popcorn.webmaker.org/commit/61e46fd4d07461b99087d98ed047a65ad128b71c

Needs verification.