959708 - [marionette-plugin-forms] setValue fails if element has not been seen before

Status: RESOLVED FIXED

(Testing Graveyard :: JSMarionette, defect)

Description

[Miller Medeiros [:millermedeiros]]

if form contain inputs missing the [type] attribute `setValue` will throw an error.

 > TypeError: Cannot call method 'trim' of undefined
 >     at Object.<anonymous> (/Users/millermedeiros/Projects/gaia/node_modules/marionette-plugin-forms/lib/index.js:30:17)

Comment 1

[Miller Medeiros [:millermedeiros]]

bug doesn't seen to be related to [type] attribute, but I will keep investigating it and push more tests.

Comment 2

[Miller Medeiros [:millermedeiros]]

Attachment: Link to github pull request

Comment 3

[Mike Pennisi [:jugglinmike]]

Comment on attachment 8359948 [details] [review]
Link to github pull request

Hey Miller,

Nice catch! Although in this case, maybe I should say "nice throw" :P Sorry to have been the cause of debugging woes.

I have one request for a change to your tests--see in-line comment on the pull request on GitHub: https://github.com/millermedeiros/marionette-plugin-forms/commit/8dccfbff2bd52aea755ea9fe3a7dd0d3bd3c0c10#commitcomment-5071195

Comment 4

[Miller Medeiros [:millermedeiros]]

(In reply to Mike Pennisi [:jugglinmike] from comment #3)
> I have one request for a change to your tests--see in-line comment on the
> pull request on GitHub:
> https://github.com/millermedeiros/marionette-plugin-forms/commit/
> 8dccfbff2bd52aea755ea9fe3a7dd0d3bd3c0c10#commitcomment-5071195

I agree with your suggestion, just updated pull request and squashed commits. Thanks for the quick response!

Comment 5

[Mike Pennisi [:jugglinmike]]

Comment on attachment 8359948 [details] [review]
Link to github pull request

Looking good, Miller; thanks!

One note about BugZilla process: I unset the "review?" flag in comment 3 to reflect the fact that I had reviewed the commit and was awaiting your response--this also removes the bug from my BugZilla dashboard [1]. If you re-set the "review?" flag, my dashboard will be updated to tell me that your patch is ready for another look.

This can seem like a lot of overhead, but it really helps reviewers to keep on top of their bugs.

[1] https://bugzilla.mozilla.org/page.cgi?id=mydashboard.html

Comment 6

[Mike Pennisi [:jugglinmike]]

master: https://github.com/mozilla-b2g/marionette-plugin-forms/commit/1edb41508c1fba6563cc241dbfc8c7dc499742a7

I've published a new release (0.0.2) so you can enjoy this change in your projects: https://github.com/mozilla-b2g/marionette-plugin-forms/commit/5fd95d7dc676d3844c4824b88e7c7a9fde756431

Comment 7

[Mike Pennisi [:jugglinmike]]

master: https://github.com/mozilla-b2g/marionette-plugin-forms/commit/1edb41508c1fba6563cc241dbfc8c7dc499742a7

(Sorry: I meant to close this in comment 6)