959758 - [Messages] Long tapping any part horizontally adjacent to a message bubble brings up the message options menu

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::SMS, defect)

Description

[KTucker [:KTucker][Inactive 3/4/2016]]

Attachment: SMSMessageOptions.txt

Description:
If the user long presses anywhere in a message thread, the message options menu appears. 

Repro Steps:
1)  Updated Buri to Build ID: 20140113004002
2)  Tap on the "SMS" app.
3)  Tap on a message to view the thread.
4)  Long press anywhere in the message thread but not on an actual message box. 

Actual:
The message options menu appears when the user taps anywhere in message thread. 

Expected:
The message options menu only appears when the user long presses on an actual message box.

Environmental Variables
Device: Buri v 1.3.0 Mozilla RIL
Build ID: 20140113004002
Gecko: http://hg.mozilla.org/releases/mozilla-aurora/rev/5bb1837de7c0
Gaia: b3fc4f712562ee92b0ed0bd17abc61be9a36a8da
Platform Version: 28.0a2

Notes:
Repro frequency: 100%
Link to failed test case: https://moztrap.mozilla.org/manage/case/7299/
See attached: video clip, logcat

Comment 1

[KTucker [:KTucker][Inactive 3/4/2016]]

Attachment: SMSMessageOptions.mp4

Comment 2

[KTucker [:KTucker][Inactive 3/4/2016]]

This issues does not occur on the Buri v 1.2.0 Mozilla RIL

Environmental Variables
Device: Buri v 1.2.0 Mozilla RIL
Build ID: 20140113004002
Gecko: http://hg.mozilla.org/releases/mozilla-b2g26_v1_2/rev/e672faf1e6a1
Gaia: 539a25e1887b902b8b25038c547048e691bd97f6
Platform Version: 26.0

The message options feature is not present in v 1.2.0

Comment 3

[Rick Waldron [:rwaldron]]

Attachment: Screen Shot 2014-01-14 at 5.17.24 PM.png

It's actually not "anywhere", just the <li> the wraps the entire row containing the message "bubble". If you "longpress" in the empty area below that, nothing happens.

Comment 4

[Rick Waldron [:rwaldron]]

Attachment: https://github.com/mozilla-b2g/gaia/pull/15326

Comment 5

[Jason Smith [:jsmith]]

Minor regression, but we should consider this for approval.

Comment 6

[Rick Waldron [:rwaldron]]

(In reply to Jason Smith [:jsmith] from comment #5)
> Minor regression, but we should consider this for approval.

It's not a regression, it always worked like this. It _is_ crappy UX and should be fixed.

Comment 7

[Julien Wajsberg [:julienw]]

Comment on attachment 8360063 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/15326

r=me with a comment that is not mandatory to fix.

Please take care to your commit log, you need the bug number on the first line.

Comment 8

[Rick Waldron [:rwaldron]]

gaia master https://github.com/mozilla-b2g/gaia/commit/482a62a47ff9cbd5dfbed8b1c03277caa88d45c3

Comment 9

[Julien Wajsberg [:julienw]]

Comment on attachment 8360063 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/15326

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): bug 927783
[User impact] if declined: strange UX behavior
[Testing completed]: yes, with unit tests
[Risk to taking this patch] (and alternatives if risky): low
[String changes made]: none

Comment 10

[Julien Wajsberg [:julienw]]

NI John for assisting the uplift. Thanks !

Comment 11

[John Ford [:jhford] CET/CEST Berlin Time]

Uplifted 482a62a47ff9cbd5dfbed8b1c03277caa88d45c3 to:
v1.3: b3485d85e1991eda8a66dc7b2db1cecc37beb056