Closed Bug 959772 Opened 6 years ago Closed 6 years ago

Create a generic PanelType and corresponding *Panel class for third-party panels

Categories

(Firefox for Android :: Awesomescreen, defect)

ARM
Android
defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 29

People

(Reporter: Margaret, Assigned: Margaret)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

PanelType.LIST was intended to do this, so let's just rename that to make it clear that it corresponds to panels that can be made to hold dynamic content, such as different sets of "widgets".
Blocks: 959777
Attached patch patchSplinter Review
Simple renaming patch, with some comments added to clarify some of our intentions.

We can work in bug 959777 to implement the real meat of this DynamicPanel class.
Attachment #8359982 - Flags: review?(lucasr.at.mozilla)
Comment on attachment 8359982 [details] [diff] [review]
patch

Review of attachment 8359982 [details] [diff] [review]:
-----------------------------------------------------------------

Awesome.

::: mobile/android/base/home/HomeConfig.java
@@ +24,5 @@
>          TOP_SITES("top_sites", TopSitesPanel.class),
>          BOOKMARKS("bookmarks", BookmarksPanel.class),
>          HISTORY("history", HistoryPanel.class),
>          READING_LIST("reading_list", ReadingListPanel.class),
> +        DYNAMIC("dynamic", DynamicPanel.class); 

nit: remove trailing space
Attachment #8359982 - Flags: review?(lucasr.at.mozilla) → review+
https://hg.mozilla.org/mozilla-central/rev/c518a5f33268
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 29
You need to log in before you can comment on or make changes to this bug.