Closed
Bug 959840
Opened 10 years ago
Closed 10 years ago
[Messages] Fix jshint failures created by 938256
Categories
(Firefox OS Graveyard :: Gaia::SMS, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: rwaldron, Assigned: rwaldron)
References
Details
Attachments
(1 file)
apps/sms/test/marionette/phone_number_service_test.js: line 3, col 5, Redefinition of 'assert'. apps/sms/test/marionette/phone_number_service_test.js: line 8, col 1, 'marionette' is not defined. apps/sms/test/marionette/phone_number_service_test.js: line 9, col 16, 'marionette' is not defined. apps/sms/test/marionette/phone_number_service_test.js: line 40, col 11, 'marionetteScriptFinished' is not defined. apps/sms/test/marionette/phone_number_service_test.js: line 6, col 24, 'TARGET_APP_MANIFEST' is defined but never used. These were introduced here https://github.com/mozilla-b2g/gaia/commit/6f577745bc0273c1bfb8612ce4a53341e2f80fc7
|
Assignee | |
Comment 1•10 years ago
|
||
Attachment #8360072 -
Flags: review?(felash)
|
||
Comment 2•10 years ago
|
||
Comment on attachment 8360072 [details] [review] https://github.com/mozilla-b2g/gaia/pull/15330 r=me once you remove this line: https://github.com/mozilla-b2g/gaia/blob/master/apps/sms/test/marionette/phone_number_service_test.js#L6
Attachment #8360072 -
Flags: review?(felash) → review+
|
|
Assignee | |
Comment 3•10 years ago
|
||
https://github.com/mozilla-b2g/gaia/commit/da6c21d784ec9fdd08ba1104b943a962a2beb800
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•