Closed
Bug 959846
Opened 10 years ago
Closed 10 years ago
Only build the js/src/assembler/assembler/*.cpp files for the targeted platform
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla29
People
(Reporter: till, Assigned: till)
Details
Attachments
(1 file)
1.29 KB,
patch
|
glandium
:
review+
|
Details | Diff | Splinter Review |
Currently, ARMAssembler.cpp, MacroAssemblerARM.cpp, and MacroAssemblerX86Common.cpp get built for all platforms, resulting in warnings about empty .o files during linking.
Assignee | ||
Comment 1•10 years ago
|
||
I hope this is the canonical way of making this conditional on the target
Attachment #8360068 -
Flags: review?(mh+mozilla)
Comment 2•10 years ago
|
||
Comment on attachment 8360068 [details] [diff] [review] Only build the js/src/assembler/assembler/*.cpp files for the targeted platform Review of attachment 8360068 [details] [diff] [review]: ----------------------------------------------------------------- r+ with nits fixed. You can probably remove the #if surrounding those file contents. ::: js/src/moz.build @@ +346,5 @@ > 'yarr/OSAllocatorPosix.cpp', > ] > > if CONFIG['ENABLE_ION'] or CONFIG['ENABLE_YARR_JIT']: > + if CONFIG['TARGET_CPU'].find('86') != -1: '86' in CONFIG['TARGET_CPU'] @@ +350,5 @@ > + if CONFIG['TARGET_CPU'].find('86') != -1: > + SOURCES += [ > + 'assembler/assembler/MacroAssemblerX86Common.cpp', > + ] > + elif CONFIG['TARGET_CPU'].find('arm') != -1: CONFIG['TARGET_CPU'].startswith('arm') or CONFIG['CPU_ARCH'] == 'arm'
Attachment #8360068 -
Flags: review?(mh+mozilla) → review+
Assignee | ||
Comment 3•10 years ago
|
||
remote: https://hg.mozilla.org/integration/mozilla-inbound/rev/23917c440e15 > You can probably remove the #if surrounding those file contents. These files are imported from JSC, so I'd rather not touch them needlessly.
Comment 4•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/23917c440e15
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla29
You need to log in
before you can comment on or make changes to this bug.
Description
•