95986 - remove references to nsImageManager

Status: VERIFIED FIXED

(Core :: Graphics: ImageLib, defect)

Description

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

References to nsImageManager should be removed since it no longer exists.  It's
currently referenced from:

gfx/public/nsGfxCIID.h
gfx/tests/btest/BitTest.cpp
webshell/tests/imgtest/ImageTest.cpp
webshell/tests/viewer/nsPhMain.cpp
webshell/tests/viewer/nsSetupRegistry.cpp (in code that should still be compiled
on Mac)

See http://lxr.mozilla.org/seamonkey/search?string=ImageManager

Comment 1

[Christian :Biesinger (don't email me, ping me on IRC)]

Attachment: Patch part 1

This removes Image Manager references from nsGfxCIID.h and win32.order.

I'm not sure if my changes to win32.order are correct, though.

I'll try the two tests later, I'm currently on linux and couldn't test my
changes. (the test directories only contain windows makefiles).

Comment 2

[Christian :Biesinger (don't email me, ping me on IRC)]

webshell/tests/imgtest/ImageTest.cpp is completely bitrotted, the makefile
doesn't even contain a REQUIRES line. The last real change (besides tree-wide
changes) was in 1999 (according to
http://bonsai.mozilla.org/cvslog.cgi?file=mozilla/webshell/tests/imgtest/ImageTest.cpp)

--> I don't think that anybody is using this test anymore, and I vote for it to
be removed.

Comment 3

[Christian :Biesinger (don't email me, ping me on IRC)]

ok. same goes for the other test (gfx/tests/btest/BitTest.cpp); this one should
also be removed imho.

Pavlov, could you review the patch now? And give your OK for removing the tests?

Comment 4

[Stuart Parmenter]

Comment on attachment 66453 [details] [diff] [review]
Patch part 1

r=pavlov

Comment 5

[tor]

Comment on attachment 66453 [details] [diff] [review]
Patch part 1

sr=tor

Comment 6

[Christian :Biesinger (don't email me, ping me on IRC)]

checked in by timeless, including the removal of the two tests

Comment 7

[Terri Preston]

Verified Source checked into lxr.mozilla.org