References to nsImageManager should be removed since it no longer exists. It's currently referenced from: gfx/public/nsGfxCIID.h gfx/tests/btest/BitTest.cpp webshell/tests/imgtest/ImageTest.cpp webshell/tests/viewer/nsPhMain.cpp webshell/tests/viewer/nsSetupRegistry.cpp (in code that should still be compiled on Mac) See http://lxr.mozilla.org/seamonkey/search?string=ImageManager
Severity: normal → trivial
Target Milestone: --- → Future
Created attachment 66453 [details] [diff] [review] Patch part 1 This removes Image Manager references from nsGfxCIID.h and win32.order. I'm not sure if my changes to win32.order are correct, though. I'll try the two tests later, I'm currently on linux and couldn't test my changes. (the test directories only contain windows makefiles).
webshell/tests/imgtest/ImageTest.cpp is completely bitrotted, the makefile doesn't even contain a REQUIRES line. The last real change (besides tree-wide changes) was in 1999 (according to http://bonsai.mozilla.org/cvslog.cgi?file=mozilla/webshell/tests/imgtest/ImageTest.cpp) --> I don't think that anybody is using this test anymore, and I vote for it to be removed.
ok. same goes for the other test (gfx/tests/btest/BitTest.cpp); this one should also be removed imho. Pavlov, could you review the patch now? And give your OK for removing the tests?
Assignee: pavlov → cbiesinger
Comment on attachment 66453 [details] [diff] [review] Patch part 1 r=pavlov
Attachment #66453 - Flags: review+
Status: NEW → ASSIGNED
Keywords: helpwanted → patch, review
Target Milestone: Future → mozilla0.9.9
Comment on attachment 66453 [details] [diff] [review] Patch part 1 sr=tor
Attachment #66453 - Flags: superreview+
checked in by timeless, including the removal of the two tests
Status: ASSIGNED → RESOLVED
Last Resolved: 17 years ago
Resolution: --- → FIXED
Verified Source checked into lxr.mozilla.org
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.