959920 - [DSDS][fugu] add a new quirk for radio control

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Vendcom, defect)

Description

[Hsin-Yi Tsai (she/her) [:hsinyi]]

We need a new quirk "ro.moz.ril.radio_off_wo_card" setting to true for controlling fugu dsds radio correctly.

Comment 1

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Hi Sam,

Could you please help this bug? We need the new quirk added to your git repo. Thanks!

Comment 2

[sam.hua]

2 in device/sprd/sp7710gaplus_gonk/base.mk 
PRODUCT_PROPERTY_OVERRIDES := \
	ro.moz.omx.hw.max_width=720 \
	ro.moz.omx.hw.max_height=576 \
	ro.moz.ril.query_icc_count=true \
	ro.moz.mute.call.to_ril=true \
	ro.moz.ril.numclients=2 \
        ro.moz.ril.data_reg_on_demand=true

changed to 
PRODUCT_PROPERTY_OVERRIDES := \
	ro.moz.omx.hw.max_width=720 \
	ro.moz.omx.hw.max_height=576 \
	ro.moz.ril.query_icc_count=true \
	ro.moz.mute.call.to_ril=true \
	ro.moz.ril.numclients=2 \
        ro.moz.ril.data_reg_on_demand=true\
        ro.moz.ril.radio_off_wo_card=true

Comment 3

[Hsin-Yi Tsai (she/her) [:hsinyi]]

I've verified the quirk has been added to fugu dsds. Thanks!

Comment 4

[Jason Smith [:jsmith]]

Clearing nom - this is vendor specific.

Comment 5

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Sam,

I saw one of your sprd commits saying "Bug #273645 disable ro.moz.ril.radio_off_wo_card function because it isn't ready." May I understand more about this? What's the problem you are facing? And is there anything that gecko could/should do for radio control on fugu? Thanks!

Comment 6

[Hsin-Yi Tsai (she/her) [:hsinyi]]

REOPEN this because it has been backed out from partner's repo. Waiting for their confirmation.

Comment 7

[sam.hua]

Hi Hsin,
it is because the phone can't find the the network of SIM2. it doesn't send RADIO_POWER(1) to RILC.

I am checking the newest code. if it works, i will add it

Comment 8

[Hsin-Yi Tsai (she/her) [:hsinyi]]

(In reply to sam.hua from comment #7)
> Hi Hsin,
> it is because the phone can't find the the network of SIM2. it doesn't send
> RADIO_POWER(1) to RILC.
> 
> I am checking the newest code. if it works, i will add it

Thanks for the reply, Sam.

If the problem you are facing is the phone can't find the the network of SIM2, I believe bug 963054 comment 3 already points the root cause. We should have a fix for bug 963054 and in the meanwhile, we add the quirk back. What do you think?

Comment 9

[sam.hua]

yes，of course. but the latest build still has this problem.

if u do need it now, i can add it back.

Comment 10

[Hsin-Yi Tsai (she/her) [:hsinyi]]

(In reply to sam.hua from comment #9)
> yes，of course. but the latest build still has this problem.
> 
> if u do need it now, i can add it back.

As we know the root cause of the problem of SIM2 network searching, I think the right direction would be fixing that on bug 963054. Removing this quirk doesn't really help resolve the issue. Instead, it distracts the whole testing process and makes us mis-report a bunch of regression bugs. Therefore, I'd like to ask for your help to add this back. Thank you, Sam.

Comment 11

[sam.hua]

Hi Hsin,
I can't add it back because i have to give our test team the build which support dual sim cards.

Comment 12

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Hi Sam,

One of the blocker of fugu radio control, bug 963054, has landed. Please check if we are fine to add the quirk back. Thank you for the help.

Comment 13

[sam.hua]

OK.
I will confirm it with latest build.

Comment 14

[sam.hua]

OK.
I will confirm it with latest build.

Comment 15

[Enpei]

Hi Sam,

Do you have latest update of this bug? We would need to build latest base image to continue our test or based on Hsinyi's comment that single SIM cases will be impacted by this bug.

Comment 16

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Sam,

If I didn't misunderstand your comment https://bugzilla.mozilla.org/show_bug.cgi?id=963054#c54, the quirk should have been added back to your repo. I repo syned this morning and didn't see it yet. Please inform us if the quirk is ready in the repo. Thank you!

Comment 17

[sam.hua]

it is updated now,please check it.

Comment 18

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Which branch should I check? sprd-aosp/sprdroid4.0_bsp?

I don't see it yet...

Comment 19

[Hsin-Yi Tsai (she/her) [:hsinyi]]

I confirmed this quirk has been added back to repo. Thanks, Sam.