959994 - [Messages] Multiple JavaScript warnings shown when launching Messages app

Status: RESOLVED WORKSFORME

(Firefox OS Graveyard :: Gaia::SMS, defect)

Description

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

E/GeckoConsole(  557): [JavaScript Warning: "Unknown property 'box-sizing'.  Declaration dropped." {file: "app://sms.gaiamobile.org/style/common.css" line: 29 column: 12 source: "  box-sizing: border-box;"}]
E/GeckoConsole(  557): [JavaScript Warning: "Unknown property 'will-change'.  Declaration dropped." {file: "app://sms.gaiamobile.org/style/common.css" line: 41 column: 13 source: "  will-change: scroll-position;"}]
E/GeckoConsole(  557): [JavaScript Warning: "Unknown property 'box-sizing'.  Declaration dropped." {file: "app://sms.gaiamobile.org/style/sms.css" line: 882 column: 17 source: "       box-sizing: border-box;"}]
E/GeckoConsole(  557): [JavaScript Warning: "Error in parsing value for 'text-overflow'.  Declaration dropped." {file: "app://sms.gaiamobile.org/style/sms.css" line: 910 column: 17 source: "  text-overflow: normal;"}]
E/GeckoConsole(  557): [JavaScript Warning: "Expected end of value but found '2.5rem'.  Error in parsing value for 'padding-left'.  Declaration dropped." {file: "app://sms.gaiamobile.org/style/sms.css" line: 969 column: 21 source: "  padding-left: 2rem 2.5rem 0 2.5rem;"}]
E/GeckoConsole(  557): [JavaScript Warning: "Error in parsing value for 'pointer-events'.  Declaration dropped." {file: "app://sms.gaiamobile.org/style/sms.css" line: 1027 column: 18 source: "  pointer-events: normal;"}]
E/GeckoConsole(  557): [JavaScript Warning: "Unknown property 'box-sizing'.  Declaration dropped." {file: "app://sms.gaiamobile.org/style/attachment.css" line: 77 column: 17 source: "       box-sizing: border-box;"}]

This happens after starting up the emulator, tested with the jb version of the emulator in pvt builds, with timestamp 20140114154437, then launching the Contacts app.

Not sure how to move this forward, setting needinfo? from Francisco, the Gaia::Contacts module owner.

Comment 1

[Francisco Jordano [:arcturus] [:francisco]]

Hi,

I guess you mean the sms app, changing it to the correct component to check it out.

Thanks!

Comment 2

[Julien Wajsberg [:julienw]]

Some of them are expected : box-sizing, will-animate.
The other are not and should be fixed, but we need to be careful to not regress.

Comment 3

[Julien Wajsberg [:julienw]]

Putting Steve as mentor.

Comment 4

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

(In reply to Francisco Jordano [:arcturus] from comment #1)
> I guess you mean the sms app, changing it to the correct component to check
> it out.

Oops, yes, I meant the SMS app, thanks!

(In reply to Julien Wajsberg [:julienw] from comment #2)
> Some of them are expected : box-sizing, will-animate.

Something to note:

https://groups.google.com/forum/#!topic/mozilla.dev.b2g/SJrBkoxWSJc

It is discussed in bug 959493 to eventually flag these types of errors as failures in TBPL.

Thus, we may still have to fix them somehow.

Comment 5

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

> Some of them are expected : box-sizing, will-animate.

That said, these issues may be related to bug 959945 and bug 959953.

Comment 6

[Julien Wajsberg [:julienw]]

bug 959945 is about an issue in a core file in Firefox, so this is quite normal that it uses the prefixed version only. But we'd like our Gaia apps to somewhat load in Chrome too (with more or less success).

JS errors are something else. What worries me is that some of the warnings are also perfectly fine. I know Gecko used to give warnings for things like "if (variable)" where variable is undefined. I don't know if that's still the case though.

Comment 7

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

> JS errors are something else. What worries me is that some of the warnings
> are also perfectly fine. I know Gecko used to give warnings for things like
> "if (variable)" where variable is undefined. I don't know if that's still
> the case though.

Nicolas, any idea?

Comment 8

[Nicolas B. Pierron [:nbp]]

(In reply to Gary Kwong [:gkw] [:nth10sd] from comment #7)
> > JS errors are something else. What worries me is that some of the warnings
> > are also perfectly fine. I know Gecko used to give warnings for things like
> > "if (variable)" where variable is undefined. I don't know if that's still
> > the case though.
> 
> Nicolas, any idea?

JavaScript reports a reference error if the variable name does not name any existing variable, which is different of it being undefined.

js> if (foo) ;
typein:1:0 ReferenceError: foo is not defined
js> var bar = undefined;
js> if (bar) ;
js>

Comment 9

[Julien Wajsberg [:julienw]]

Yep, right :) But I can reasonnably argue that when a undeclared variable name "foo" is used in such a construct "if (foo)", it's quite a good code.

Comment 10

[kumar rishav (:rishav_)]

Hi Juliew , Steve

I would like to work on this bug.Please assign this to me. Also, please provide  more details, if it needs.

Thanks

Comment 11

[Julien Wajsberg [:julienw]]

I assigned you to bug 959201 which is more important, so I won't assign you here. Thanks!

Comment 12

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

I no longer see JavaScript warnings when launching either the Contacts or the Messages app.

Tested with the Flame on:

$ ./check_versions.sh
Gaia      0f9f11d0a6dadb3ea27160204bbe911c1ad69a6f
Gecko     https://hg.mozilla.org/mozilla-central/rev/196d05832e12
BuildID   20140709040203
Version   33.0a1
ro.build.version.incremental=109
ro.build.date=Mon Jun 16 16:51:29 CST 2014
B1TC00011220