Closed
Bug 960028
Opened 10 years ago
Closed 10 years ago
Use UndefinedHandleValue rather than rooting UndefinedValue()
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla30
People
(Reporter: jonco, Assigned: jonco)
References
Details
Attachments
(1 file)
26.35 KB,
patch
|
sfink
:
review+
|
Details | Diff | Splinter Review |
A quick grep finds a whole bunch of places where we do this.
Assignee | ||
Updated•10 years ago
|
Blocks: ExactRooting
Assignee | ||
Comment 1•10 years ago
|
||
So this changes places where we root just to get an undefined value with UndefinedHandleValue, and removes explicit initialization of a rooted to undefined as it's the default anyway.
Attachment #8372857 -
Flags: review?(sphink)
Comment 2•10 years ago
|
||
Comment on attachment 8372857 [details] [diff] [review] bug960028-undefined-value Review of attachment 8372857 [details] [diff] [review]: ----------------------------------------------------------------- ::: js/src/builtin/TestingFunctions.cpp @@ +688,5 @@ > CountHeap(JSContext *cx, unsigned argc, jsval *vp) > { > CallArgs args = CallArgsFromVp(argc, vp); > > + RootedValue startValue(cx); I'd rather leave this one as-is. It's documentation for the initial value. ::: js/src/jsfun.cpp @@ +887,5 @@ > return false; > } > > Value *argv = vp + 2; > + RootedValue thisv(cx); I'd leave this one alone too. ::: js/src/vm/Debugger.cpp @@ +1235,5 @@ > * pending exception for a 'catch' clause to handle. Don't let the > * onStep handlers mess with that (other than by returning a resumption > * value). > */ > + RootedValue exception(cx); Leave this one alone. ::: js/src/vm/OldDebugAPI.cpp @@ +621,5 @@ > > RootedObject obj(cx, obj_); > > bool wasThrowing = cx->isExceptionPending(); > + RootedValue lastException(cx); Leave this one alone.
Attachment #8372857 -
Flags: review?(sphink) → review+
Assignee | ||
Comment 3•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/9bbd70722bde
Comment 4•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/9bbd70722bde
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla30
You need to log in
before you can comment on or make changes to this bug.
Description
•